Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 212537

Summary: Remove references to internal APIs.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: critical    
Priority: P1 CC: jerome.bozier
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 208583    
Bug Blocks:    

Description Paul Slauenwhite CLA 2007-12-11 08:52:53 EST
Remove references to internal APIs.

plugins/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/wizard/DatapoolImportPageSelection.java:
52:import org.eclipse.ui.internal.ide.IDEWorkbenchMessages;
53:import org.eclipse.ui.internal.ide.IIDEHelpContextIds;
54:import org.eclipse.ui.internal.ide.misc.ResourceAndContainerGroup;
Comment 1 Paul Slauenwhite CLA 2007-12-11 10:38:32 EST
The following files checked-in to CVS (HEAD):

org.eclipse.hyades.test.ui.internal.wizard.WizardMessages.java
/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/wizard/messages.properties

Still need to resolve:

54:import org.eclipse.ui.internal.ide.misc.ResourceAndContainerGroup;
Comment 2 Paul Slauenwhite CLA 2008-01-30 12:14:35 EST
Deferred from I5 to I6 with PMC approval.
Comment 3 Paul Slauenwhite CLA 2008-03-04 14:25:27 EST
Refactored the new, export, and import wizard UIs to be consistent in their layout and messages:


org.eclipse.hyades.test.ui.internal.resources.UiPluginResourceBundle.java
/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/resources/messages.properties
org.eclipse.hyades.test.ui.internal.wizard.DatapoolCSVImportPage.java
org.eclipse.hyades.test.ui.internal.wizard.DatapoolExportCSVFileLocationPage.java
org.eclipse.hyades.test.ui.internal.wizard.DatapoolImportPage.java
org.eclipse.hyades.test.ui.internal.wizard.DatapoolImportPageSelection.java
Comment 4 Paul Slauenwhite CLA 2008-03-06 08:47:24 EST
Refactored a large majority of the datapool import wizard to remove the internal reference and reuse the org.eclipse.hyades.ui.internal.wizard.LocationPage.java for consistency across all TPTP import/new wizards.

Also, added a progress bar for long running import operations.

Finally, added calls to open the Test Perspective and datapool editor (depending the on the user preference - see https://bugs.eclipse.org/bugs/show_bug.cgi?id=206356) after the import operation is complete.

The following files checked in to CVS (HEAD):

org.eclipse.hyades.test.ui.internal.util.TestUIUtilities.java
org.eclipse.hyades.test.ui.internal.resources.UiPluginResourceBundle.java
/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/resources/messages.properties
org.eclipse.hyades.test.ui.internal.wizard.DatapoolImportPageTwo.java
org.eclipse.hyades.test.ui.internal.wizard.DatapoolImportWizard.java
org.eclipse.hyades.test.ui.internal.wizard.WizardMessages.java
/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/wizard/messages.properties
org.eclipse.hyades.ui.internal.wizard.LocationPage.java
Comment 5 Paul Slauenwhite CLA 2008-06-10 09:57:21 EDT
Verified in http://download.eclipse.org/tptp/4.5.0/dev/TPTP-4.5.0-200806080100/internal-pkg-use.txt.  Closing.