Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 212252

Summary:

[templates] improve logging when reading templates into ContributionTemplateStore

Product:

[Eclipse Project] Platform

Reporter:

Stephan Wahlbrink <sw>

Component:

Text

Assignee:

Platform-Text-Inbox <platform-text-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert

Version:

3.4

Keywords:

helpwanted

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none

Description Stephan Wahlbrink

2007-12-07 05:26:25 EST

It would be very helpful to find errors in templates,
if caught TemplateExceptions in
  ContributionTemplateStore#invalidateTemplate(...)
would be logged.

Comment 1 Dani Megert

2007-12-10 06:03:15 EST

>ContributionTemplateStore#invalidateTemplate(...)
You mean ContributionTemplateStore#validateTemplate(...), right?

We already log some stuff but miss some places:
- when template is contributed directly in plugin.xml
- when context is wrong

Comment 2 Stephan Wahlbrink

2007-12-20 04:07:08 EST

Yes, you are right, #validateTemplate(...)

My templates -contributed by plugin.xml- was invalid, and it is difficult to find the error, when the exception is not handled.

Comment 3 Dani Megert

2007-12-20 04:21:52 EST

A patch would be welcome.

Comment 4 Stephan Wahlbrink

2008-01-02 04:38:03 EST

Created attachment 85976 [details]
Proposed patch

Proposed patch adds TemplateException as nested info to log entry.

(Stephan Wahlbrink <stephan.wahlbrink@walware.de>)

Comment 5 Dani Megert

2008-01-29 08:35:47 EST

Thanks for the patch!
Fixed in HEAD.
Available in builds > I20080129-0800.