Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 211729

Summary: Problems in displaying Hebrew (Bi-Directional) text in the TPTP Log Viewer
Product: z_Archived Reporter: Kiran M N <mn.kiran>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
RMT Script and Execution Log
none
Screen capture #1.
none
Screen capture #2.
none
UNSUPPORTED Patched Plug-in.
none
UNSUPPORTED Patched Plug-in (TPTP 4.2.2).
none
Screen capture of this behavior in the consuming product.
none
Example RMT script containing hebrew text.
none
Example RMT execution log with problem
none
Screen capture #3 none

Description Kiran M N CLA 2007-12-03 05:47:15 EST
In Rational Manual Tester(RMT), we use TPTP log viewer to display the log / result of executing a script.
In case of Hebrew (which is a bi-directional language), some statements in the Events Tab, does not appear Right to Left justified. While, they appear properly (Right to Left justified) in editor while Authoring. The log file ends with ".execution", which is nothing but a TPFTestSuite file.

The steps to reproduce this scenario is provided below:
1. On a WinXP box, go to Start Menu > Control Panel > Regional and Language Settings.
2. In the Regional Options Tab, Standards and formats group, select the language as Hebrew.
3. In the Advanced Tab, Language for non-Unicode programs group, select the language as Hebrew.
4. Open the file LoginHeb_Log.execution (attached), in the TPTP Log Viewer (org.eclipse.hyades.test.ui.forms.editor.TestLogViewer).
5. Click on the Events Tab.
6. Under the Events section, notice that the statements are displayed from Left to Right justified.
7. Click on one of those events, notice that the statements are displayed from Left to Right justified, in the Text section also.

Note: When we start RMT using the -nl he option, all the views are displayed in Right to Left justified and the logs in the log viewer too. However, when the system settings are changed as given above, the views are Left to Right justified. Please mail to kiran.m.n@in.ibm.com, for more information / questions.

Attachment Details: RMT-Scripts.zip contains LoginHeb.rmt(script) and LoginHeb_Log.execution(execution log). Both are TPFTestSuite files, and execution log can be opened by org.eclipse.hyades.test.ui.forms.editor.TestLogViewer.
Comment 1 Kiran M N CLA 2007-12-03 05:50:21 EST
Created attachment 84300 [details]
RMT Script and Execution Log
Comment 2 Paul Slauenwhite CLA 2007-12-03 14:54:45 EST
Assuming this defect was found in TPTP 4.5.
Comment 3 Paul Slauenwhite CLA 2007-12-19 07:05:45 EST
This defect is required by a consuming product early in I5. 
Comment 4 Paul Slauenwhite CLA 2008-01-07 15:20:47 EST
Hi Kiran, can you prvide screen captures of this behavior?
Comment 5 Paul Slauenwhite CLA 2008-01-07 15:36:47 EST
Created attachment 86346 [details]
Screen capture #1.

Using the Eclipse default locale (English).
Comment 6 Paul Slauenwhite CLA 2008-01-07 15:37:09 EST
Created attachment 86347 [details]
Screen capture #2.

Using the Eclipse HE locale.
Comment 7 Paul Slauenwhite CLA 2008-01-07 15:39:40 EST
Kiran, what is the expected behavior?  In the case of the selected node in the Events tree, are you expecting the text to be "PassWord &#1492;&#1511;&#1513;"?
Comment 8 Kiran M N CLA 2008-01-16 07:13:55 EST
When the script contains a mix of Hebrew and English, RMT displays the characters incorrectly in the  log. Instead of taken the same order of the script, RMT sorts the character strings. RMT puts Hebrew strings with Hebrew strings and English strings to English strings.

Example:

The script's text is:
ךנװפ שפן blaBla ךנװפ שפן

The logs distorts the infoprmation into:

ךנװפ שפןךנװפ שפן blaBla
Comment 9 Paul Slauenwhite CLA 2008-01-18 10:40:55 EST
Checked the following files into CVS (HEAD):

/features/org.eclipse.tptp.test/feature.xml
/org.eclipse.hyades.test.ui/META-INF/MANIFEST.MF
org.eclipse.hyades.test.ui.forms.base.ExecutionEventDetailsPart.java
org.eclipse.hyades.test.ui.internal.editor.form.util.EventLabelProvider.java


Kiran, can you verify that this fix (see the attached patch) resolves the problem with the consuming product?
Comment 10 Paul Slauenwhite CLA 2008-01-18 10:42:16 EST
Created attachment 87272 [details]
UNSUPPORTED Patched Plug-in.

Note: This patched plug-in is for testing purposes ONLY and should not be shipped with any consuming product.
Comment 11 Paul Slauenwhite CLA 2008-01-22 13:49:39 EST
Created attachment 87541 [details]
UNSUPPORTED Patched Plug-in (TPTP 4.2.2).

TPTP 4.2.2 version of the patched plug-in:

Note: This patched plug-in is for testing purposes ONLY and should not be shipped with any consuming product.
Comment 12 Paul Slauenwhite CLA 2008-01-23 09:13:11 EST
Created attachment 87649 [details]
Screen capture of this behavior in the consuming product.
Comment 13 Paul Slauenwhite CLA 2008-01-23 14:44:10 EST
This problem was still evident in the Properties view of the Test Perspective when the user selects the element in the Test Log View.  

The following class checked-in to CVS (HEAD):

org.eclipse.hyades.ui.adapter.NamedElementPropertySource.java
Comment 14 Kiran M N CLA 2008-01-29 01:47:37 EST
Created attachment 88095 [details]
Example RMT script containing hebrew text.

Example RMT script containing hebrew text.
Comment 15 Kiran M N CLA 2008-01-29 01:48:26 EST
Created attachment 88096 [details]
Example RMT execution log with problem
Comment 16 Paul Slauenwhite CLA 2008-01-30 13:52:39 EST
(In reply to comment #15)
> Created an attachment (id=88096) [details]
> Example RMT execution log with problem
> 

This test log is being rendered correctly in TPTP 4.2.2 using the Hebrew locale since the text attributes in the test log (unzip using WinZip) are rendered correctly in teh 4.2.2 Test Log View (see attached screen capture). 
Comment 17 Paul Slauenwhite CLA 2008-01-30 13:53:03 EST
Created attachment 88320 [details]
Screen capture #3
Comment 18 Paul Slauenwhite CLA 2008-01-30 14:00:53 EST
(In reply to comment #16)
> (In reply to comment #15)
> > Created an attachment (id=88096) [details] [details]
> > Example RMT execution log with problem
> > 
> 
> This test log is being rendered correctly in TPTP 4.2.2 using the Hebrew locale
> since the text attributes in the test log (unzip using WinZip) are rendered
> correctly in teh 4.2.2 Test Log View (see attached screen capture). 
> 

Note, these findings were based on the GAed 4.2.2 driver WITHOUT the patch for this defect (see comment #11).   

The fix for this defect was for a problem in TPTP 4.5 where the Latin letters were swapped, which was fixed by the patch (see comment #10).  For example:

&#1492;&#1511;&#1513; UserName

was displayed as:

UserName &#1492;&#1511;&#1513;
Comment 19 Paul Slauenwhite CLA 2008-06-11 07:15:06 EDT
Closing.