Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 211610

Summary: [Forms] Adopt new MPE key binding API
Product: [Eclipse Project] Platform Reporter: Adam Archer <agarcher>
Component: User AssistanceAssignee: Adam Archer <agarcher>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cgold, curtispd, pwebster
Version: 3.4   
Target Milestone: 3.4 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 184074    
Bug Blocks:    
Attachments:
Description Flags
patch none

Description Adam Archer CLA 2007-11-30 11:54:52 EST 
Created attachment 84202 [details]
patch

Internal code was used as a temporary fix for bug 177331 and API was requested to avoid this in bug 184074. This API is almost ready and the changes need to be adopted by forms.

Attached is a slightly modified version of the patch from bug 184074 comment 4. The only difference is that I removed a comment about the temporary fix. This patch depends on the patch for the MultiPageEditorPart in bug 184074 comment 3, so the commits should be coordinated.
Comment 1 Adam Archer CLA 2007-11-30 11:59:25 EST 
Chris, this patch is ready to go. It needs to go in before the I-build on Tuesday, but we should wait for the final go-ahead from Paul.

Paul, let us know when the platform patch for bug 184074 is in and we will follow suit.

Note, the fix for bug 210753 is included in the patch in comment 0.
Comment 2 Paul Webster CLA 2007-11-30 12:10:32 EST 
OK, I've applied our fix for MultiPageEditorPart from  bug 184074

You guys should be good to go.

PW
Comment 3 Adam Archer CLA 2007-11-30 12:15:00 EST 
*** Bug 210793 has been marked as a duplicate of this bug. ***
Comment 4 Chris Goldthorpe CLA 2007-11-30 12:39:24 EST 
I have committed the changes to org.eclipse.ui.forms to HEAD. I'll do the examples also but first we should decide what the best way to not break 3.3 users is, options include tagging the examples with an R3_3 tag, adding comments by the new lines on what to do to make them work with 3.3 or both.
Comment 5 Paul Webster CLA 2007-11-30 12:58:47 EST 
(In reply to comment #4)
> I have committed the changes to org.eclipse.ui.forms to HEAD. I'll do the
> examples also but first we should decide what the best way to not break 3.3
> users is, options include tagging the examples with an R3_3 tag, adding
> comments by the new lines on what to do to make them work with 3.3 or both. 
> 

Oh, I included changes in the example to make sure that the services API was working, but they're not really necessary.

You can do what you think is best.

PW
Comment 6 Adam Archer CLA 2007-11-30 14:11:00 EST 
Chris, I don't think we need to apply the changes to the Examples plug-in. The changes are somewhat hidden and very specific to testing this bug.
Comment 7 Chris Goldthorpe CLA 2007-11-30 15:01:09 EST 
OK I'll leave the examples as is. Setting state to FIXED.