Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 211518

Summary: [General designer usability] Removing Formatting from the GUI
Product: z_Archived Reporter: Mark <meraso>
Component: BIRTAssignee: Chen Chao <cchen>
Status: VERIFIED FIXED QA Contact: Maggie Shen <lshen>
Severity: normal    
Priority: P3 CC: bchanchoke, bluesoldier, rkanguri, wenfeng.fwd, zqian
Version: 2.2.0Keywords: plan
Target Milestone: 2.5.0 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard: Obsolete
Attachments:
Description Flags
mock up for the solution
none
Restore / Default Properties none

Description Mark CLA 2007-11-29 16:33:12 EST
There are some formatting buttons in the Property Editor that once applied to an element cannot be removed, such as the font-weight and the text-align buttons. If clicked, the XML is written (i.e. font-weight: bold). If unclicked, the XML is updated (i.e. font-weight: normal). This is an issue if later a style is applied to the element (specifically, a style defined by a CSS file in a libraried theme). The element's specific formatting overrides the style (rightly so), but if you add a style after the fact you would likely wish to remove all formatting from the element, and have it controlled by the style.

The workarounds are to either delete from the XML directly, or to delete the element and add it back to the layout. There should be a method to unset the formatting though. Font-face, font-size, font-color all have an Auto option in the drop down box, which cleanly drops the value from the XML, allowing the style to handle formatting.
Comment 1 Zhiqiang Qian CLA 2007-12-06 22:35:42 EST
We need enhance the UI design to address such issues.
Comment 2 lifeng li CLA 2008-10-02 15:24:37 EDT
Created attachment 114131 [details]
mock up for the solution
Comment 3 lifeng li CLA 2008-10-02 15:25:36 EDT
mock up attached.
Comment 4 Rima Kanguri CLA 2008-11-12 15:49:58 EST
Comment from Zhiqiang
I suggest we use a toolbar button with an icon on the top-right area of the property pane, so this will not affect current property page layout and is more consistent across pages.

I agree with the suggestion. Boonboon will update the mockup
Comment 5 Boonboon Chanchoke CLA 2008-11-12 19:26:22 EST
Created attachment 117729 [details]
Restore / Default Properties
Comment 6 Boonboon Chanchoke CLA 2008-11-12 19:31:56 EST
The mock up has been updated. To reduce confusion between a default properties button and restore library properties, I'd like to suggest the tool tip text on the Restore Properties icon to read "Restore properties from the original library item".

The suggested UI is included on the attachment slide #@. 



Comment 7 Rima Kanguri CLA 2009-02-02 18:34:47 EST
Zhiqiang, can this be completed in milestone 5?
Comment 8 Zhiqiang Qian CLA 2009-02-03 01:19:41 EST
(In reply to comment #7)
> Zhiqiang, can this be completed in milestone 5?
> 
We'll try to fit the timeline.
Comment 9 Chen Chao CLA 2009-02-05 01:30:34 EST
Fixed it by the mockup.
Comment 10 Maggie Shen CLA 2009-02-06 05:27:55 EST
verified on build 2.5.0 v20090206-1116.
Comment 11 Rima Kanguri CLA 2009-05-15 13:59:52 EDT
As part of this enhancement a new property called 'locale' is supported for Data Report Item - format category, what this means is user can set locale along with the format for data item