| Summary: | [Markers] Marker#checkInfo need to include a stack trace | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tod Creasey <Tod_Creasey> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | RESOLVED WONTFIX | QA Contact: | Hitesh <hsoliwal> |
| Severity: | minor | ||
| Priority: | P3 | CC: | bokowski, john.arthorne |
| Version: | 3.4 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows Vista | ||
| Whiteboard: | |||
|
Description
Tod Creasey
Marker.checkInfo doesn't log anything, it just throws an exception. This is a case of a client catching the CoreException thrown by resource API, and then logging CoreException.getStatus() and throwing the exception away. Thanks John - I discovered that later and should have added something myself. I can add my own stack trace but it seemed to be something that would be useful for people who were logging the exception. It looks like these log entries are coming from:
org.eclipse.ui.internal.provisional.views.markers.MarkerEntry
There are several places where it does this after calling IMarker API:
} catch (CoreException e) {
StatusManager.getManager().handle(e.getStatus());
}
Since you are logging only the status and discarding the exception object, you are throwing away the stack trace.
Same problem in MarkersPropertyPage. You probably don't even need to be logging these exceptions - it just means the marker no longer exists (for example perhaps a build was running in the background and removed it). I am only logging these in debug mode now I don't think this is a problem now that the exception is only logged when a particular debug option is enabled. Ordinary users won't be bothered by this. |