Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 210722

Summary: cstring C++ standarts conformance
Product: z_Archived Reporter: Vasily v. Levchenko <vasily.v.levchenko>
Component: TPTPAssignee: Guru Nagarajan <guru.nagarajan>
Status: CLOSED FIXED QA Contact:
Severity: trivial    
Priority: P1 CC: asaf.yaffe
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Attachments:
Description Flags
fix strchr C++ conformance none

Description Vasily v. Levchenko CLA 2007-11-23 02:37:02 EST
Created attachment 83606 [details]
fix strchr C++ conformance 

Hi folks, 
I've noticed some incorrect using of const-less strchr in Martini/Infrastructure/common/bootloaderoptionparser.cpp  sources that has got an error severity in modern compilers. 

hint:
char *strchr(
   const char *str,
   int c 
);  // C only
char *strchr(
   char *str,
   int c 
); // C++ only
const char *strchr(
   const char * str,
   int c 
); // C++ only

solution see in attached patch
Comment 1 Asaf Yaffe CLA 2007-11-25 03:57:00 EST
Already fixed in latest 4.5/HEAD branch
Comment 2 Guru Nagarajan CLA 2007-11-26 23:46:55 EST
setting ver
Comment 3 Paul Slauenwhite CLA 2009-06-30 13:45:28 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 4 Paul Slauenwhite CLA 2009-06-30 14:02:56 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.