Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 210684

Summary:

disable all operations in the Task Repositories view for a disconnected repository

Product:

z_Archived

Reporter:

Shawn Minto <shawn.minto>

Component:

Mylyn

Assignee:

Shawn Minto <shawn.minto>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

Keywords:

helpwanted

Version:

unspecified

Target Milestone:

2.2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none
mylyn/context/zip	none

Description Shawn Minto

2007-11-22 11:48:36 EST

If a repository is marked as disconnected, the context menu in the Task Repositories View should not allow the user to make a query or a task.

Comment 1 Mik Kersten

2007-11-26 23:29:32 EST

Shawn: could you provide a patch?

Comment 2 Shawn Minto

2007-11-27 14:57:33 EST

I should be able to look into this later this week.

Comment 3 Shawn Minto

2007-12-03 17:04:53 EST

Created attachment 84363 [details]
patch

Attached is a patch that adds a property for whether the repository is online and adds the check for this property in the enablement of the contributed actions.

Comment 4 Shawn Minto

2007-12-03 17:04:55 EST

Created attachment 84364 [details]
mylyn/context/zip

Comment 5 Steffen Pingel

2007-12-04 22:26:59 EST

Updated IP log and applied the patch with minor modifications: renamed the property to "offline" to make it consistent with rest of the API and made the property check compare the specified value.

The patch does not set the enabled state for the "Update Attributes" menu item. Should that be disabled for offline repositories as well?

Comment 6 Shawn Minto

2007-12-05 11:43:25 EST

 (In reply to comment #5)
> The patch does not set the enabled state for the "Update Attributes" menu item.
> Should that be disabled for offline repositories as well?
I thought that this would be ok to leave since it shouldn't bring up any wizards that may require contacting the repository and therefore should fail gracefully.  I can create another patch to address this if you wanted.

Comment 7 Steffen Pingel

2007-12-05 13:17:23 EST

Okay, we can leave it for now as "Update Attributes" only invokes a method on the connector that can handle it appropriately.