Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 210641

Summary:

URL Recorder operational messages require cleanup.

Product:

z_Archived

Reporter:

Paul Slauenwhite <paulslau>

Component:

TPTP

Assignee:

DuWayne Morris <dmorris>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

Keywords:

plan

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Screen capture.	none
Additional patch.	none

Description Paul Slauenwhite

2007-11-22 06:30:18 EST

URL Recorder operational messages require cleanup.

(see enclosed screen capture)
-spacing (e.g. between command and Init)
-paths (e.g. /t/eqm.testsuite)
-grammar (e.g. connecting to 'the' Agent Controller
-add descriptions following the commmands (e.g. Sending command 'init' to initialize the recording agent).  


Also, the URL recorder operational messages are written to the Eclipse .log file and these messages should be written only to the Recorder Console view.

For example:

!ENTRY org.eclipse.hyades.test.core 1 1 2007-11-21 12:43:06.220
!MESSAGE about to load recorder agent: 
org.eclipse.hyades.execution.recorder.http.remote.SSLProxyRecorder

!ENTRY org.eclipse.hyades.test.core 1 1 2007-11-21 12:43:06.632
!MESSAGE load successful

!ENTRY org.eclipse.hyades.test.core 1 1 2007-11-21 12:43:06.632
!MESSAGE about to initialize recorder agent: 
org.eclipse.hyades.execution.recorder.http.remote.SSLProxyRecorder

!ENTRY org.eclipse.hyades.test.core 1 1 2007-11-21 12:43:06.632
!MESSAGE initialization successful

!ENTRY org.eclipse.hyades.test.core 1 1 2007-11-21 12:43:06.983
!MESSAGE about to start SSLProxyServer

!ENTRY org.eclipse.hyades.test.core 1 1 2007-11-21 12:43:06.987
!MESSAGE proxy recorder listening to port1080

Comment 1 Paul Slauenwhite

2007-11-22 06:30:56 EST

Duwayne, please provide a sizing.

Comment 2 Paul Slauenwhite

2007-11-22 06:49:56 EST

Created attachment 83523 [details]
Screen capture.

Comment 3 Paul Slauenwhite

2008-03-11 13:09:18 EDT

When going a simple recording with Eclipse started in -console mode using the latest code in CVS, the following operational messages were emitted to the console and .log file:

Console:

osgi> "C:\Program Files\Internet Explorer\IEXPLORE.EXE"
recorder stopper thread started with name: Recorder Process Stopper
about to wait for process
about to load recorder agent: org.eclipse.tptp.test.recorders.url.runner.interna
l.SSLProxyRecorder
load successful
about to initialize recorder agent: org.eclipse.tptp.test.recorders.url.runner.i
nternal.SSLProxyRecorder
initialization successful
about to start SSLProxyServer
proxy recorder listening to port1080
process terminated


.log file:

!SESSION 2008-03-11 14:02:49.787 -----------------------------------------------
eclipse.buildId=I20080207-1530
java.fullversion=J2RE 1.5.0 IBM J9 2.3 Windows XP x86-32 j9vmwi3223ifx-20070323 (JIT enabled)
J9VM - 20070322_12058_lHdSMR
JIT  - 20070109_1805ifx3_r8
GC   - WASIFIX_2007
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_CA
Command-line arguments:  -os win32 -ws win32 -arch x86 -clean -console -data D:\AC_Hyades_WSAD_Drivers\4.5I5\eclipse\workspace

!ENTRY org.eclipse.hyades.test.core 1 1 2008-03-11 14:03:35.068
!MESSAGE about to load recorder agent: org.eclipse.tptp.test.recorders.url.runner.internal.SSLProxyRecorder

!ENTRY org.eclipse.hyades.test.core 1 1 2008-03-11 14:03:36.708
!MESSAGE load successful

!ENTRY org.eclipse.hyades.test.core 1 1 2008-03-11 14:03:36.740
!MESSAGE about to initialize recorder agent: org.eclipse.tptp.test.recorders.url.runner.internal.SSLProxyRecorder

!ENTRY org.eclipse.hyades.test.core 1 1 2008-03-11 14:03:36.740
!MESSAGE initialization successful

!ENTRY org.eclipse.hyades.test.core 1 1 2008-03-11 14:03:36.755
!MESSAGE about to start SSLProxyServer

!ENTRY org.eclipse.hyades.test.core 1 1 2008-03-11 14:03:36.865
!MESSAGE proxy recorder listening to port1080

Only exceptions and warnings should be logged to the .log file.  Recording activity should be written to the recording console.  If DEBUG logging is required, it should be logged to a proper Java Logger and the logging level should be OFF by default.

Comment 4 DuWayne Morris

2008-03-18 16:43:45 EDT

Cleaned up to avoid these messages in InternetExplorerAdapter.java, RecorderAgentController.java, and RecorderStopper.java, with provisions to turn-on this output if needed by setting a class DEBUG boolean.

Comment 5 Paul Slauenwhite

2008-04-10 06:25:28 EDT

Created attachment 95494 [details]
Additional patch.

Checked-in to CVS (HEAD).

Comment 6 DuWayne Morris

2008-06-09 09:10:52 EDT

Fixed and verified, closing.