Bugzilla – Full Text Bug Listing
| Summary: | Task, Category and Query should display # children, offspring and cyclic state in properties view | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | maarten meijer <mjmeijer> | ||||||
| Component: | Mylyn | Assignee: | maarten meijer <mjmeijer> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | steffen.pingel | ||||||
| Version: | dev | ||||||||
| Target Milestone: | 2.2 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 341079 | ||||||||
| Attachments: |
|
||||||||
|
Description
maarten meijer
Created attachment 83516 [details]
Extend the Mylyn IPropertySource with children count, offspring count, and cyclic test
Can be helpful for diagnosing current bugs with improper label decorations
Created attachment 83517 [details]
mylyn/context/zip
Steffen: please review. Thanks Maarten. I have applied the patch with minor modifications: I removed empty comments and JavaDoc tags (e.g. @param adaptableObject) and formatted the source code using our formatting rules. It would be great if you could run that on each file (Edit -> Format) before submitting patches. Other than reformatting I renamed AbstractMylynPropertySource to AbstractTaskContainerPropertySource to reflect its purpose and removed an unused constructor. I was wondering if we still need the Repository Spy view or if the same information is available from the properties view now? +1 for removing view in a favor of extending support for the Properties view (In reply to comment #4) > Thanks Maarten. I have applied the patch with minor modifications: I removed > empty comments and JavaDoc tags (e.g. @param adaptableObject) and formatted the > source code using our formatting rules. It would be great if you could run that > on each file (Edit -> Format) before submitting patches. Other than reformatting > I renamed AbstractMylynPropertySource to AbstractTaskContainerPropertySource to > reflect its purpose and removed an unused constructor. I have the mylyn formatter rulse imported in my mylyn workspace, so that should be no problem I'll make it an aut save action. Hmm, the auto-save action can not be shared through import/export, but are settable on a project basis. > I was wondering if we still need the Repository Spy view or if the same > information is available from the properties view now? Properties are (1) read only and (2) only visible when the object is selected The view always visible and allows you to delete individual properties, so they revert to their defaults. I was thinking of making them all editable and adding a little search button so you can enter the property name and the tree will shrink. Lets get feedback from connector developers before removing again... I think it is a bad idea to edit repository configuration from outside repository editing dialog. Also not sure about use cases for seeing the spy view all the time (In reply to comment #7) > I think it is a bad idea to edit repository configuration from outside > repository editing dialog. > Also not sure about use cases for seeing the spy view all the time Spy view is used by developers when working on a connector, like I did with bug 207498. Its in dev tools sandbox so not expected to be visible all the time. Each view adds an additional overhead to the UI. It need to be placed somewhere in workbench window and also clutters the view selection list. I am not so much concerned about having additional views contributed by the sandbox but I would like to avoid having two separate UIs for the same functionality and duplicated code that needs to be maintained. (In reply to comment #6) > I have the mylyn formatter rulse imported in my mylyn workspace, so that should > be no problem > I'll make it an aut save action. The Mylyn Java formatting rules should be enabled for each Mylyn project. Please let me know if that is not the case. I am in favor of enabling automatic formatting on save which is discussed on bug 210040. > > I was wondering if we still need the Repository Spy view or if the same > > information is available from the properties view now? > Properties are (1) read only and (2) only visible when the object is selected > The view always visible and allows you to delete individual properties, so they > revert to their defaults. Would it be possible to make them editable/deletable from the property view? I am not sure if (2) is important enough since it easy to select the object in the repository view. Do you have a special use case in mind where you require the properties be visible all the time? Marking resolved as the functionality requested in this bug has been implemented. |