Bugzilla – Full Text Bug Listing
| Summary: | Add option for downloading the TPTP Profiler Development SDK to the TPTP 4.5 download page | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Asaf Yaffe <asaf.yaffe> | ||||||||||||
| Component: | TPTP | Assignee: | Joel Cayne <jcayne> | ||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||
| Severity: | enhancement | ||||||||||||||
| Priority: | P1 | CC: | chris.l.elford, guru.nagarajan, jcayne, jgwest, jkubasta, kiryl.kazakevich, paulslau, sluiman | ||||||||||||
| Version: | unspecified | Keywords: | plan | ||||||||||||
| Target Milestone: | --- | Flags: | jcayne:
review+
asaf.yaffe: review+ paulslau: review+ |
||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| URL: | http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_210191.htm | ||||||||||||||
| Whiteboard: | closed460 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Asaf Yaffe
There are "Stand-alone Offerings" and "Agent Controller" section in TPTP download page. As JVMTI profiler is not part of AC, I think Profiler SDK is better to place to "Stand-alone Offerings" section. Guru, Could you please provide title and text for Profiler SDK which should be placed on TPTP download page? (In reply to comment #1) I agree that the profiler SDK should appear in the Standalone Offerings section. My suggestion for title and texts for the download page: Title: Java 1.5+ (JVMTI) Profiler SDK Text: The Java 1.5+ Profiler SDK package contains code and libraries for developing profiling tools for Java Below the text, the page should contain a selection box (for selecting a platform) titled "SDK:", and a "Download" button Asaf, I have checked in your modifications of makefiles with minor fixes. I have replaced leading spaces by tab and modified makefile for linux systems replacing hard coded IA32 to ${EXTENS}.
The next step is to update build scripts. Then download page can be modified.
(In reply to comment #3) Thanks Kiryl, I will review the updated make files. Anything else you need from me? It seems no, Asaf. I have checked in updated build scripts. Created attachment 84735 [details]
Add JVMTI profiler SDK to TPTP download page
Joanna,
Could you please review the attached patch and commit it?
Thanks,
Kiryl
This is in effect an enhancement as we are requesting a packaging add/change. I think we should also call this "JVMTI agent SDK" and create an agent download section that follows the Agent Controller section (as opposed to putting it on the site as a standalone offering). In addition to having a section of agent downloads and SDKs, ther should also be a single runtime that contains them all for a user to pull for a remote system along with the agent controller. Asaf, would you please create a FDD? I will then request AG review and PMC approval. Created attachment 85001 [details]
Feature Description Document
I have attached an FDD for this feature.
Joanna, please review and assign resources and time estimates (currently missing from FDD), and then check-in this document (I have no permissions for doing this).
Thanks,
Asaf
Created attachment 85019 [details]
Updated FDD
Joel, please verify sizings (person hours) FDD added to CVS; URL field updated AG approved for the 4.5 release with the following comments: -There is no sizing for initial testing of the new packages. -How will these packages be tested in each iteration? There is no sizing for creating new test cases. -We should be more clear on the Java level that each package supports. It is critical that the user know exactly what is in each package, their dependencies, and the purpose of each package. For example, The Java 1.5+ Profiler SDK package contains code and libraries for developing profiling tools for Java 1.5+ only. -The JVMPI package should be able to support Java 1.4.x and 1.5.x. -I have added this feature to the 4.5 Release Plan (http://www.eclipse.org/tptp/home/project_info/devplans/Eclipse%20TPTP%20Project%204.5%20Release%20Plan.htm#Features). (In reply to comment #12) > -The JVMPI package should be able to support Java 1.4.x and 1.5.x. Paul, just fyi, with TPTP 4.4 we do not support or encourage the use of PI with 1.5.x. 1.5 is supported in prior releases only. This was done to simplify the user experience and reduce our test effort for a component we intend to deprecate (jvmpi) If this Bugzilla is planed to be completed in 4.5, please add the plan keyword. Otherwise, please target to future. In addition, if this Bugzilla is committed to be completed in 4.5, please change the priority to P1. In plan for 4.5. (In reply to comment #13) > (In reply to comment #12) > > > -The JVMPI package should be able to support Java 1.4.x and 1.5.x. > > Paul, just fyi, with TPTP 4.4 we do not support or encourage the use of PI with > 1.5.x. 1.5 is supported in prior releases only. This was done to simplify the > user experience and reduce our test effort for a component we intend to > deprecate (jvmpi) > Thanks Harm for the clarification. This should be made explicit in the JRE/OS support statement for 4.4.x (http://www.eclipse.org/tptp/home/project_info/releaseinfo/4.4/support.html). Asaf, Jonathan, In order for Joel and Kiryl to create the necessary packages for web download, they need to be given the appropriate build information. Asaf: please let Joel know the features/plugins for the JVMTI SDK and what JVMTI features/plugins need to be included in the common agent Runtime. Jonathan: please let Joel know the features/plugins for the JVMPI SDK and what JVMPI features/plugins need to be included in the common agent Runtime. (In reply to comment #17) > Asaf: please let Joel know the features/plugins for the JVMTI SDK and what > JVMTI features/plugins need to be included in the common agent Runtime. The JVMTI SDK is in the org.eclipse.tptp.platform.jvmti.runtime component.The default make target builds packages for both runtime (named javaprofiler.<os>_<arch>.zip) and SDK (named javaprofiler.<os>_<arch>.sdk.zip). Please let me know if you need anything else. Can someone estimate when will the SDK be available for download? Jonathan, Reassigning to you to provide the required information for JVMPI. Once the JVMPI component is available, we will add both components to the webpage. Hi Asaf, it's unclear to me which functionality/libraries you're looking for. Are you looking for the JVMPI profiler agent source (org.eclipse.tptp.platform.agentcontroller\src-native-new\src\agents\native\) or are you looking for the C/Java agent code for writing old execution framework agents (org.eclipse.hyades.execution and various libraries from org.eclipse.tptp.platform.agentcontroller\src-native-new\src\)? (In reply to comment #21) Jonathan, I am not sure I understand your question... I am looking for neither of these... This Bugzilla refers to adding an option for downloading the JVMTI Profiler SDK (see comment 18). We are currently in the process of publishing a paper about the JVMTI Profiler SDK and we need to have a public place from which readers can download this SDK, preferably in the next 2 weeks. In comment 19, I just wanted to know when will the update to the download page happen... Thanks, Asaf Hi Asaf, you are only looking for the option of downloading the JVMTI SDK, right? You don't need JVMPI, I presume? (In reply to comment #23) > Hi Asaf, you are only looking for the option of downloading the JVMTI SDK, > right? You don't need JVMPI, I presume? > Correct. For my purposes, I need only the JVMTI SDK to be available. It would seem that the original point of this bug was to post the JVMTI profiler SDK for a paper that Asaf is working on. However, the JVMPI requirement seems to have been slipped into this defect somewhat surreptitiously. Since there is no officially designated JVMPI Profiler SDK, and because Asaf wants his changes in ASAP, I would recommend closing this bug as JVMTI only, and if we want a JVMPI Profiler SDK we should open a new enhancement bug where we can discuss what it would contain. Consequently, I am reassigning the bug to Joel to check in any JVMTI changes, and to update Asaf on when these changes will be available. I absolutely agree. A JVMPI SDK download section (if such SDK exists) can be added later. I really need the JVMTI SDK to be available for download in the next 2 weeks. Thanks, Asaf (In reply to comment #26) > I absolutely agree. A JVMPI SDK download section (if such SDK exists) can be > added later. I really need the JVMTI SDK to be available for download in the > next 2 weeks. > > Thanks, > Asaf > Agreed, and to be clear there is no request or need for a PI based SDK Created attachment 88931 [details]
Add JVMTI profiler SDK to TPTP download page - 2
I have created a new patch moving the download below the Agent Controller in a new Agents section.
Are the javaprofiler.<platform>-<build id>.zip driver files for the runtime section?
I believe the packaging might need updating. Unzipping javaprofiler.all_platforms.sdk-<build id>.zip and javaprofiler.all_platforms-<build id>.zip has the directory tptp as the root. Should it be eclipse/plugins?
(In reply to comment #28) > Are the javaprofiler.<platform>-<build id>.zip driver files for the runtime > section? Yes. > > I believe the packaging might need updating. Unzipping > javaprofiler.all_platforms.sdk-<build id>.zip and > javaprofiler.all_platforms-<build id>.zip has the directory tptp as the root. > Should it be eclipse/plugins? > The structure of the "all_platforms" package is not really important since you cannot just extract it into an existing Agent Controller installation. In my opinion, we can remove the "all platform" package from the download page. I don't see the value of this package. Thanks, Asaf Created attachment 89009 [details]
Add JVMTI profiler SDK to TPTP download page - 3
I have updated the patch with a new runtime drop down as described in the Feature Description Document.
Patch checked into HEAD. Please see a driver of TPTP-4.5.0-200802061010 or later. I confirm that the Feb 6 driver contains an option to download the JVMTI Profiler SDK. Good job! Thanks a lot! Asaf As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |