Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 209594

Summary:

execution environment warning/error is invalid on resource only plugin

Product:

[Eclipse Project] PDE

Reporter:

David Williams <david_williams>

Component:

Assignee:

Chris Aniszczyk <caniszczyk>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

baumanbr, caniszczyk

Version:

3.4

Target Milestone:

3.4 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
team project set to import an example from WTP	none
org.eclipse.pde.patch	none
mylyn/context/zip	none

Description David Williams

2007-11-12 23:25:21 EST

I know, I know ... you do something cool and people still complain! :) 

I do like the new (M3) warning for missing execution environment's, but, we in WTP (at least) have a number of "resource only" bundles for info/help and seems to me there should be no error given there. They don't have any java code in them, there is no Java Nature, etc.

Some time ago, I once asked some experts on what to do about EE for resource only bundles and they recommended it be left out ... that was consistent with the "specify as little as required" philosophy ... there really is no restriction for resource only bundles, and my request to add a "resource-only" execution environment to OSGi did not gain much support, and in fact my bug 189579 for that very issues was "dup'd" to the very bug to flag missing EE's ... by someone who will now hate reading this bug :) 

So, now I have the opposite request, sort of ... don't flag them if there's no reason for one.

Comment 1 Chris Aniszczyk

2007-11-12 23:37:33 EST

Fair enough :)

Comment 2 Chris Aniszczyk

2007-11-12 23:38:54 EST

By resource only, you mean they aren't Java project or they don't contain code?

Do you have an example from WTP?

Comment 3 David Williams

2007-11-12 23:58:45 EST

Created attachment 82725 [details]
team project set to import an example from WTP

Correct, not a java project, and there is no executable code. 

Just xml/html files for help, is one common example. 

I think there are others though, that, for example only contain "definitions" of servers, and similar.

Comment 4 Chris Aniszczyk

2007-11-13 00:11:02 EST

Created attachment 82726 [details]
org.eclipse.pde.patch

Here we go.

1) We only validate for BREE's if we're a java project

2) If you specify a new plug-in project and it's not a java project, we won't set a BREE on project creation and gray out the BREE box.

Comment 5 Chris Aniszczyk

2007-11-13 00:11:07 EST

Created attachment 82727 [details]
mylyn/context/zip

Comment 6 Chris Aniszczyk

2007-11-13 00:12:06 EST

Quick turnaround time, just for David :)

Comment 7 Brian Bauman

2007-12-11 12:28:47 EST

verified on I20071211-0010