Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 209343

Summary: Binary Data Transfer Format for Profiling (Client-side)
Product: z_Archived Reporter: Stanislav Polevic <stanislav.v.polevic>
Component: TPTPAssignee: Stanislav Polevic <stanislav.v.polevic>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: analexee, asaf.yaffe, chris.l.elford, guru.nagarajan, igor.alelekov, jkubasta, kiryl.kazakevich, mikhail.sennikovskiy, nmehrega, paulslau, stanislav.v.polevic
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: closed460
Bug Depends on: 209342    
Bug Blocks: 196713    
Attachments:
Description Flags
Initial implementation of the BF loader
none
BF UI support
none
Binary loader implementation after internal code review
none
BF UI support after code review
none
Two system messages are introduced
none
BF UI support
none
BF parser and message loaders
none
Handshaking protocol
none
BF support in TI
none
BF parser and message loaders
none
Handshaking protocol none

Description Stanislav Polevic CLA 2007-11-09 09:59:14 EST
Implement binary format loader.
Introduce new trace file type for import (binary).
Implement negotiation protocol at the client side.
Comment 1 Stanislav Polevic CLA 2008-02-14 09:13:43 EST
Initial implementation of the client-side will be attached soon.
However I am targeting it to 4.5i6.
Comment 2 Stanislav Polevic CLA 2008-02-19 09:54:55 EST
Created attachment 90067 [details]
Initial implementation of the BF loader

Standalone trace file loader implementation.
Trace file must have .trcbin extension.
Comment 3 Stanislav Polevic CLA 2008-02-19 09:56:09 EST
Created attachment 90070 [details]
BF UI support

Support for binary format trace files in the Probing file import wizard.
Comment 4 jkubasta CLA 2008-02-20 08:39:34 EST
Stanislav, are you ready to have these patches reviewed?
Comment 5 Stanislav Polevic CLA 2008-02-20 09:00:38 EST
Well, basically, yes.
But I think it would be reasonable to do after internal TI team code review which is held at this Friday.
Comment 6 Stanislav Polevic CLA 2008-02-22 05:28:31 EST
Created attachment 90455 [details]
Binary loader implementation after internal code review

Changes:
- code is split to internal and external parts
- inappropriate comments are removed
Comment 7 Stanislav Polevic CLA 2008-02-22 05:29:47 EST
Created attachment 90456 [details]
BF UI support after code review

Changes:
- comments are removed
Comment 8 Stanislav Polevic CLA 2008-02-26 11:56:42 EST
Created attachment 90762 [details]
Two system messages are introduced

Changes:
- new parser for system message providing character encoding 
- new parser for system message providing CPU max qualified frequency
Comment 9 Stanislav Polevic CLA 2008-03-21 09:43:56 EDT
Created attachment 93128 [details]
BF UI support

Changes:
- import wizard page can filter by ".trcbin" files in file chooser
- import wizard is able to import BF trace files transparently
Comment 10 Stanislav Polevic CLA 2008-03-21 09:46:00 EDT
Created attachment 93129 [details]
BF parser and message loaders

This patch contains complete set of BF parsers and loaders for the version 1.0 of the Binary Format
Comment 11 Stanislav Polevic CLA 2008-03-21 09:50:18 EDT
Created attachment 93130 [details]
Handshaking protocol

This patch contains handshaking protocol implementation on the client side.
Comment 12 Stanislav Polevic CLA 2008-03-21 09:52:21 EDT
Created attachment 93131 [details]
BF support in TI

This patch contains necessary changes for BF support in controlled/enabled execution modes.
Comment 13 Stanislav Polevic CLA 2008-03-21 09:53:34 EDT
Igor, could you, please, review these patches and commit them into repository.
Comment 14 Stanislav Polevic CLA 2008-03-21 12:12:22 EDT
Created attachment 93147 [details]
BF parser and message loaders

Fix timestamp conversion truncation.
Comment 15 Stanislav Polevic CLA 2008-03-21 12:15:47 EDT
Created attachment 93149 [details]
Handshaking protocol

Now client always tries to use BF first in controlled mode.
Comment 16 Alexander N. Alexeev CLA 2008-03-24 11:16:12 EDT
patches are committed to the HEAD 
Comment 17 jkubasta CLA 2008-03-24 11:31:02 EDT
Resolving defect as fixed. Please reopen if problem found during test pass.
Comment 18 Paul Slauenwhite CLA 2009-06-30 10:37:47 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.