Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 208897

Summary:	[OLE] PartInitException opening an OLE editor
Product:	[Eclipse Project] Platform	Reporter:	Tod Creasey <Tod_Creasey>
Component:	UI	Assignee:	Dani Megert <daniel_megert>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	major
Priority:	P3	CC:	daniel_megert, emoffatt, Szymon.Brandys, tomasz.zarna
Version:	3.4
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:

Description Tod Creasey

2007-11-06 10:06:20 EST

M4

If I double click on a .bmp file I get the following exception


org.eclipse.ui.PartInitException: Invalid Input: org.eclipse.ui.part.FileEditorInput(/org.eclipse.platform/splash.bmp).  Input must adapt to IFile
	at org.eclipse.ui.internal.editorsupport.win32.OleEditor.validatePathEditorInput(OleEditor.java:472)
	at org.eclipse.ui.internal.editorsupport.win32.OleEditor.init(OleEditor.java:442)
	at org.eclipse.ui.internal.EditorManager.createSite(EditorManager.java:794)
	at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:643)
	at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:426)
	at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:594)
	at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:300)
	at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
	at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
	at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
	at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:472)
	at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1256)
	at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1209)
	at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1604)
	at org.eclipse.ui.internal.PartStack.add(PartStack.java:499)
	at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103)
	at org.eclipse.ui.internal.PartStack.add(PartStack.java:485)
	at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112)
	at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63)
	at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:217)
	at org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:207)
	at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:774)
	at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:673)
	at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:634)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2719)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2633)
	at org.eclipse.ui.internal.WorkbenchPage.access$12(WorkbenchPage.java:2625)
	at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2577)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2572)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2556)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2547)
	at org.eclipse.ui.ide.IDE.openEditor(IDE.java:644)
	at org.eclipse.ui.ide.IDE.openEditor(IDE.java:603)
	at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:318)
	at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:160)
	at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:222)
	at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:203)

Comment 1 Dani Megert

2007-11-06 10:29:50 EST

I'll take a look as I recently fixed bug 206752.

Comment 2 Dani Megert

2007-11-06 11:20:48 EST

Mmh, ugly. The fix I made for bug 206752 is correct but fails because of the invalid/unexpected implementation of FileEditorInput.getAdapter (see bug 120336) which results in the fact that 'null' is returned to clients who asks for an adapter that is indeed implemented by FileEditorInput.

I'll see what we can do.

Comment 3 Dani Megert

2007-11-06 11:22:23 EST


*** This bug has been marked as a duplicate of bug 120336 ***

Comment 4 Eric Moffatt

2007-11-08 13:41:34 EST

I'll have to check this tomorrow, it seems to work on 3.3.1 (the install I have on my laptop).

Comment 5 Dani Megert

2007-11-09 02:31:43 EST

>I'll have to check this tomorrow, it seems to work on 3.3.1 (the install I have
>on my laptop).
It worked in 3.3.1 (please read comment 2).