Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 208623

Summary: NullPointerException at org.eclipse.hyades.sdb.internal.actions.ActionHandlerListener.updateActions logged
Product: z_Archived Reporter: Alex Nan <apnan>
Component: TPTP.monitoringAssignee: Yasuhisa Gotoh <gotohy>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 Keywords: plan
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
Patch file
none
Revised patch file none

Description Alex Nan CLA 2007-11-02 17:05:01 EDT
java.lang.NullPointerException
at org.eclipse.hyades.sdb.internal.actions.ActionHandlerListener.updateActions(ActionHandlerListener.java:346)
at org.eclipse.hyades.sdb.internal.actions.ActionHandlerListener.menuShown(ActionHandlerListener.java:438)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:947)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:971)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:952)
at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:4096)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:3800)
at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:334)
at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1559)
at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:1880)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4423)
at org.eclipse.swt.internal.win32.OS.DefWindowProcW(Native Method)
at org.eclipse.swt.internal.win32.OS.DefWindowProc(OS.java:2315)
at org.eclipse.swt.widgets.Shell.callWindowProc(Shell.java:457)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:3862)
at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:334)
at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1559)
at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:1880)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4423)
at org.eclipse.swt.internal.win32.OS.DefWindowProcW(Native Method)
at org.eclipse.swt.internal.win32.OS.DefWindowProc(OS.java:2315)
at org.eclipse.swt.widgets.Shell.callWindowProc(Shell.java:457)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:3862)
at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:334)
at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1559)
at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:1880)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4423)
at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2320)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3353)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2395)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2359)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2225)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:468)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:463)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:362)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:175)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:515)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:455)
at org.eclipse.equinox.launcher.Main.run(Main.java:1193)
at org.eclipse.equinox.launcher.Main.main(Main.java:1169)
Comment 1 Alex Nan CLA 2007-11-02 17:06:50 EDT
Targetting to 4.5 i2 since this is not a major problem but we need to reduce as much as possible the pollution of the Eclipse .log  file.
Comment 2 Alex Nan CLA 2007-11-02 17:09:12 EDT
Gotoh-san please take a look, it's just a simple checking if an action is not null. Thanks. 
Comment 3 Alex Nan CLA 2007-11-05 18:20:50 EST
Changing target to 4.5 i4.
Comment 4 Yasuhisa Gotoh CLA 2007-11-16 06:42:25 EST
Created attachment 83057 [details]
Patch file

I have created a patch for this problem. Please review.
Comment 5 Alex Nan CLA 2007-11-16 12:36:01 EST
To be on the safe side verify for null values each action separately before setting any value on it.
Comment 6 Yasuhisa Gotoh CLA 2007-11-18 21:58:58 EST
Created attachment 83208 [details]
Revised patch file

Here is the revised patch.
Comment 7 Alex Nan CLA 2007-11-19 13:41:47 EST
OK, it looks good.
Comment 8 Yasuhisa Gotoh CLA 2007-11-21 02:55:22 EST
Code checked in
Comment 9 Alex Nan CLA 2008-06-27 20:29:11 EDT
Verified with TPTP-4.5.0 GA.
Comment 10 Alex Nan CLA 2008-06-27 20:29:23 EDT
Closing.