Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 208390

Summary:

[Markers] Improve 'No Quick Fix' dialog from new Marker view

Product:

[Eclipse Project] Platform

Reporter:

Martin Aeschlimann <martinae>

Component:

Assignee:

Tod Creasey <Tod_Creasey>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.3

Target Milestone:

3.4 M4

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

208478

Bug Blocks:

Attachments:

Description	Flags
screenshot	none
Patch for those items that are not covered by Bug 208478	none

Description Martin Aeschlimann

2007-11-01 07:53:44 EDT

20071101-0010

- In the new markers view select a problem marker with no quick fix, for example a syntax error in a Java file
- Open the context menu and invoke 'Quick Fix'

This opens a warning dialog that is not so helpful. See screenshot.

a. Message says: No fixes found (Time of error: ...).
This is a warning, not an error. I don't see the advantage of knowing the time of error/warning.

b. 'Reason: Check the details' is strange.
The reason doesn't seem to be necessary. It doesn't say more.

c. The dialog title should be the same as the name of the action the user just called: 'Quick Fix'
It should use title capitalization, see Guideline 1.5
http://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html

Comment 1 Martin Aeschlimann

2007-11-01 07:54:08 EDT

Created attachment 81849 [details]
screenshot

Comment 2 Tod Creasey

2007-11-01 16:45:31 EDT

Bug 208478 describes the use of an error dialog for warnings and infos.

Comment 3 Tod Creasey

2007-11-01 16:48:14 EDT

Created attachment 81885 [details]
Patch for those items that are not covered by Bug 208478

Comment 4 Tod Creasey

2007-11-05 08:10:45 EST

Patch released for build >20071105

Comment 5 Tod Creasey

2007-12-11 12:48:06 EST

The new Quick Fix command is not enabled in this case anymore (unless there is some way to do this I am unaware of).