Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 207575

Summary: VerifyError during profiling of project with AspectJ "set pointcut"
Product: z_Archived Reporter: Pavel Vojtechovsky <pvojtechovsk>
Component: TPTPAssignee: Yunan, He <yunan.he>
Status: CLOSED WONTFIX QA Contact: Kathy Chan <kathy>
Severity: normal    
Priority: P3 CC: analexee, asaf.yaffe, jgwest, jkubasta, yunan.he
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed471
Attachments:
Description Flags
zip file with testing Eclipse project none

Description Pavel Vojtechovsky CLA 2007-10-26 09:41:04 EDT
Created attachment 81262 [details]
zip file with testing Eclipse project

Build ID: M20070921-1145

Steps To Reproduce:
1.instal Eclipse using
- tptp.runtime.allInOne.win32.win32.x86-TPTP-4.4.0.3.zip
- ajdt_1.5_for_eclipse_3.3.zip
2. install agntctrl.win_ia32-TPTP-4.4.0.zip and configure it  to use jdk1.5.0_12
3. run ...\AgentController\bin\ACServer.exe
4. run Eclipse using jdk1.5.0_12
5. import testing project from attached zip. There are 2 java classes and 1 aspect.
6. Try to run test.TestAJ_TPTP class. It should produce output
> Wrapper works
7. Try to profile test.TestAJ_TPTP class using "Execution time analysis" with default options.
it fails with:

Exception in thread "main" java.lang.VerifyError: (class: test/Events, method: ajc$around$test_Events$1$12b03786proceed signature: (Ljava/lang/Object;Ljava/util/Collection;Lorg/aspectj/runtime/internal/AroundClosure;)V) Inconsistent stack height 1 != 2
	at test.Entity.<init>(Entity.java:7)
	at test.TestAJ_TPTP.main(TestAJ_TPTP.java:13)


More information:
Comment 1 Guru Nagarajan CLA 2007-11-13 13:35:16 EST
We have not validated the profiler with Aspects and specifically applications that instrument the code.
We will take a peek at your application to understand whats going on.

Comment 2 Asaf Yaffe CLA 2007-11-14 07:57:36 EST
This bug is most likely caused by instrumentation conflicts with the AspectJ instrumentor/weaver. Root-cause is still unknown.

There are several workarounds for this issue:

1. Exclude AspectJ-generated code from profiling by adding the following filter to the Profiling Agent:
Class=* Method=ajc* Rule=EXCLUDE

2. Use an IBM 1.5 JVM. For some reason, this JVM does not reject the instrumented classes (actually, it may indicate a bug in the IBM JVM verifier...)

Comment 3 Paul Slauenwhite CLA 2007-12-19 07:45:44 EST
If this Bugzilla is planed to be completed in 4.5, please add the plan keyword.  Otherwise, please target to future.

In addition, if this Bugzilla is committed to be completed in 4.5, please change the priority to P1.
Comment 4 Asaf Yaffe CLA 2007-12-20 01:06:04 EST
In plan for 4.5. Reassigning to myself.
Comment 5 Asaf Yaffe CLA 2008-04-13 06:26:07 EDT
Not sure about the importance of this use-case. Reducing priority. May be containable in 4.5.i7
Comment 6 Asaf Yaffe CLA 2008-04-29 06:25:22 EDT
May be containable in i8.
Comment 7 jkubasta CLA 2008-05-14 11:17:32 EDT
Not containable in 4.5.0
Comment 8 Harm Sluiman CLA 2009-01-21 10:17:37 EST
cleaning up assignees
Comment 9 Paul Slauenwhite CLA 2009-07-03 07:49:25 EDT
Kathy, please triage.
Comment 10 Paul Slauenwhite CLA 2010-03-10 12:23:08 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 11 Kathy Chan CLA 2010-11-18 18:50:54 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.