Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 20729

Summary: internal error on commit
Product: [Eclipse Project] Platform Reporter: Adam Kiezun <akiezun>
Component: TeamAssignee: Kevin McGuire <Kevin_McGuire>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: cagatayk, James_Moody, Michael.Valenta, rodrigo
Version: 2.0   
Target Milestone: 2.0 F4   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Adam Kiezun CLA 2002-06-20 11:51:02 EDT 
20020619

not sure how to reproduce

!STACK 0
java.lang.NullPointerException
	at org.eclipse.team.internal.ccvs.core.client.Request.executeRequest
(Request.java:179)
	at org.eclipse.team.internal.ccvs.core.client.ValidRequests.execute
(ValidRequests.java:24)
	at org.eclipse.team.internal.ccvs.core.client.Session.open
(Session.java:319)
	at org.eclipse.team.internal.ccvs.core.CVSTeamProvider.checkin
(CVSTeamProvider.java:319)
	at org.eclipse.team.internal.ccvs.ui.RepositoryManager.commit
(RepositoryManager.java:682)
	at org.eclipse.team.internal.ccvs.ui.actions.CommitAction$1.execute
(CommitAction.java:39)
	at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run
(WorkspaceModifyOperation.java:64)
	at org.eclipse.core.internal.resources.Workspace.run
(Workspace.java:1361)
	at org.eclipse.ui.actions.WorkspaceModifyOperation.run
(WorkspaceModifyOperation.java:78)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run
(ModalContext.java:98)
Comment 1 Adam Kiezun CLA 2002-06-20 11:52:12 EDT 
i used 'Commit' directly from the team menu
Comment 2 Kevin McGuire CLA 2002-06-20 14:46:55 EDT 
Not much to go on.  Mike can you have a look?
Comment 3 Michael Valenta CLA 2002-06-20 14:54:33 EDT 
*** Bug 20728 has been marked as a duplicate of this bug. ***
Comment 4 Michael Valenta CLA 2002-06-20 14:57:34 EDT 
The offending code is the following method in ValidRequests:

public IStatus execute(Session session, IProgressMonitor monitor) 
    throws CVSException {

    return executeRequest(session, null, monitor);
}

We are passing null as the message listener because we don't espect any 
message. However, the server is giving us an error message for some reason. The 
error is most likely due to some temporary server state (perhaps caused by a 
lot of traffic?).
Comment 5 Kevin McGuire CLA 2002-06-20 15:03:06 EDT 
*** Bug 20750 has been marked as a duplicate of this bug. ***
Comment 6 Kevin McGuire CLA 2002-06-20 15:30:43 EDT 
Adam, was this against dev.eclipse.org or your local server?
Comment 7 Adam Kiezun CLA 2002-06-21 04:28:40 EDT 
dev.eclipse.org
Comment 8 Michael Valenta CLA 2002-06-21 11:11:03 EDT 
*** Bug 20771 has been marked as a duplicate of this bug. ***
Comment 9 Michael Valenta CLA 2002-06-21 12:12:56 EDT 
Code updated to log message from server and fail more gracefully.
Fix verified by KM and McQ
Comment 10 Antonio D'souza CLA 2002-06-26 14:31:19 EDT 
Mike's fix seems to handle the possibikity of having a null listener if the
response is "E". Looks good to me.