Bugzilla – Full Text Bug Listing
| Summary: | [context] editors from second window not restored upon activation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Robert Elves <robert.elves> | ||||||
| Component: | Mylyn | Assignee: | Shawn Minto <shawn.minto> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | minor | ||||||||
| Priority: | P4 | CC: | mik.kersten, rolf, shawn.minto, steffen.pingel | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 3.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Robert Elves
I think that it is important to restore the users entire state when a task is activated since when a task is deactivated all of editors close in all windows. There is a mismatch between what is restored on activation and what is closed on task deactivation which can disorient the user especially if there are some key files open in the second window. Will this be looked at for Mylyn 3.0? This is currently not a priority for Mylyn 3.0. Shawn, would you be willing to investigate a solution? There could be some priority here if there is an impact on API. Either way, the best chances of having it in 3.0 is to provide a patch with test coverage. Created attachment 98198 [details]
patch
Here is a patch that makes restoring editors for multiple workbench windows work. Right now, this is always on, but we could add a couple preferences to modify the behavior and whether it is supported. The basic idea for how this works is that it tries to restore the editors to the window that they were originally in by using the window number. If this doesn't work (i.e. one of the windows is closed), the active window gets the editors from the closed window. The preferences that could be created are:
* Restore the active window on save to the current active window if there is no match for the saved window and that window was active
* Restore all windows to the active window if there is no match for the saved window
I also added API in MonitorUi for getting the launching workbench window and the monitored windows and have updated the ContextEditorManager to use these API's instead of using the MonitorUiPlugin.
Created attachment 98199 [details]
mylyn/context/zip
Wow, awesome. Patch applied. |