Bugzilla – Full Text Bug Listing
| Summary: | [Preferences] Preferences filters should use visible strings, not programmatic keywords | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Carl Manaster <manaster> | ||||
| Component: | IDE | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Kevin_McGuire, ob1.eclipse, remy.suen | ||||
| Version: | 3.3 | Keywords: | helpwanted | ||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | stalebug | ||||||
| Attachments: |
|
||||||
|
Description
Carl Manaster
Created attachment 80697 [details]
Patch to add 'open' and 'recent' as keywords for the 'Editors' preference page.
Carl, unfortunately the preference page search is based on hand coded keywords (as Remy's helpful patch shows, thanks!). If you notice any others feel free to log them. Carl, do you want a bug to track the larger issue (ie. pref filter is unreliable because it requires hand coded keywords)? If so I'm sure there's a pre-existing that you can add your CC to. We'd like to use this one to fix the actual "recently" not working. Hi, Kevin, Thanks. Yes, I think the larger issue is more important; when I want something in preferences, then whatever words are going to show up in the dialog when I'm at that page, should lead me to that page. Fixing "recent" or "recently" is nice, but what I think really needs to happen is that users know they can absolutely rely on the filter. And it strikes me as a lot simpler to "virtually" build all the dialog pages and index their words than to keep a manual index. I can envision manual hints - where, say, synonyms appear - but I would expect the core to be based around the text that actually gets displayed. Not just "would", but "did" - and I had that (misplaced) absolute confidence, which is why I "knew" there wasn't a "recent files" setting. Finally, I think the automated system would give better support for i18n issues - whatever text is going to get used in the dialog, in the user's language, will get searched. But I've no objection to your using this bug for the "recent files" issue alone. Just, please look after the bigger issue, too. Thanks! Moving to the [Preferences] bucket since the big issue suggests that we consider the page content, not the programmatic keywords. This would be an API change and probably worth considering in the e4 timeframe. See also bug 69200 which discusses having filtered lists/trees available everywhere. I can still imagine that the way in which the filter hits are computed could be left up to the individual component, so I've left this bug open. Remy or Oleg - can someone review/release the patch? I would have just done it if I had IDE from HEAD in my workspace but I'm working in a branch right now and in the middle of moving a bunch of bugs. I created a separate bug 296640 for Remy's patch and applied it to CVS Head. (Thanks by the way! :-).) The ideas in this bug make a lot of sense. There is also related bug 203792 about being able to match multiple keywords. I'll add "helpwanted" to this bug - if anybody has time, this should be an interesting task to solve. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |