Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 206769

Summary:

[change method signature] incorrect visibility after changing base class

Product:

[Eclipse Project] JDT

Reporter:

Karsten Silz <karsten.silz>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

martinae

Version:

3.3.1

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

stalebug

Attachments:

Description	Flags
Dialog and source code are out of sync	none

Description Karsten Silz

2007-10-18 10:55:27 EDT

I have a base class with a method declared as abstract and public; this method is overwritten in two derived classes.  I changed the visibility of the abstract methods in the base class to protected and then went into the derived class where the method was still declared as public.  On this method, I selected "Refactor - Change Method Signature..." which first warned me that this was declared in the base class.  I selected "Yes", and the refactoring dialog popped up.

Now the problem is that in this dialog, the visibility of the method was already set to protected (as in the base class) and not public (as it actually was in the derived class).  So I couldn't change the visibility of the derived method because "Ok" was disabled for "protected" (screenshot to follow).

I think this is a bug - the dialog should be based on what is in the derived class, not what the base class declares.

Comment 1 Karsten Silz

2007-10-18 10:56:45 EDT

Created attachment 80666 [details]
Dialog and source code are out of sync

Comment 2 Jerome Lanneluc

2007-10-18 11:07:19 EDT

Moving to JDT/UI

Comment 3 Eclipse Genie

2020-03-05 17:34:48 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.