Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 206499

Summary: Symptom catalog import not showing error message when incorrect import format is chosen
Product: z_Archived Reporter: Liz Dancy <lizdancy>
Component: TPTP.monitoringAssignee: Yasuhisa Gotoh <gotohy>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: apnan, prafulr, zung
Version: unspecifiedKeywords: plan
Target Milestone: ---Flags: apnan: review? (gotohy)
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Attachments:
Description Flags
Patch file
none
Updated patch
apnan: review+
Second updated patch
none
Updated patch none

Description Liz Dancy CLA 2007-10-16 12:51:28 EDT 
Try to import a symptom catalog from a remote host which should be imported using the Symptom v2.0 import format but select the IBM Websphere proprietary import format instead.

Notice that no error message is displayed but the import will either run out of memory if the catalog is large or import the catalog with no symptoms.
Comment 1 Alex Nan CLA 2007-10-16 15:00:37 EDT 
This defect will be solved once 204035 is solved.
Comment 2 Alex Nan CLA 2007-11-20 10:08:47 EST 
Assigning to i4, this is a defect that needs to be done.
Comment 3 Yasuhisa Gotoh CLA 2007-12-07 06:39:24 EST 
Created attachment 84718 [details]
Patch file

Alex, please review the patch.
Comment 4 Alex Nan CLA 2007-12-07 19:47:12 EST 
Created attachment 84794 [details]
Updated patch

Gotoh-san I have reviewed your patch but I don't think this is the best way to solve the problem. We shouldn't parse the whole file just to find out at the end that the catalog is in an invalid format, we just need to parse the first element.
For sake of consistency I have added a similar logic for the case in which a Websphere format symptom catalog is imported using the symptom 2 importer. Now the validation is upfront and is more efficient. Please take a look, test and refine the fix. I haven't touched the zip handlers which are a special case and a bit more difficult to add validation code.
I am gonna retarget the defect to 4.5 i5 since it obviously cannot be contained in i4.
Thanks.
Comment 5 Alex Nan CLA 2007-12-07 19:48:50 EST 
Readjust sizing.
Comment 6 Alex Nan CLA 2007-12-07 19:53:08 EST 
Created attachment 84795 [details]
Second updated patch

I missed to adda file in the previous patch.
Comment 7 Alex Nan CLA 2007-12-10 11:40:49 EST 
Created attachment 84877 [details]
Updated patch

This patch is better.
Comment 8 Alex Nan CLA 2008-01-16 01:57:27 EST 
Fixed.
Comment 9 Paul Slauenwhite CLA 2009-06-30 10:30:33 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.