Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 206393

Summary: Add "Attach screenshot" to task editor context menu
Product: z_Archived Reporter: Willian Mitsuda <wmitsuda>
Component: MylynAssignee: Mik Kersten <mik.kersten>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P5    
Version: dev   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
mylyn/context/zip none

Description Willian Mitsuda CLA 2007-10-15 17:57:23 EDT
Task editor has a "Attach file..." action on context menu. Now that we have a "attach screenshot", it should be there too.
Comment 1 Mik Kersten CLA 2007-10-16 23:42:06 EDT
I'm a bit torn on this one.  "Attach File" we know to be a common action, whereas "Attach Screenshot" is a more specialized action and mostly used for bug reporting.  I'd like to leave this open for now, and consider further when we next iterate on the editor and its actions.
Comment 2 Willian Mitsuda CLA 2007-10-17 00:54:28 EDT
I missed that because I actually only use the context menu to attach things. Right-click -> Attach file.

It is the quickest way to invoke attach. The another way involves having to scroll the task editor to the attachment section, expand it and then press the button. I rarely use the last one.
Comment 3 Eugene Kuleshov CLA 2007-10-17 11:54:08 EDT
+1 for adding screenshot action to context menu

Personally I am either using drag and drop when attaching files or attaching from the clipboard, but "attach file" is really weird action name for creating attachments from the clipboard...
Comment 4 Willian Mitsuda CLA 2007-10-17 12:36:06 EDT
(In reply to comment #3)
> Personally I am either using drag and drop when attaching files or attaching
> from the clipboard, but "attach file" is really weird action name for creating
> attachments from the clipboard...
> 

Good point. I think "attach file" sounds strange to me because most times I use it to attach patches from clipboard.
Comment 5 maarten meijer CLA 2007-10-17 14:50:32 EDT
Attach from...?
Comment 6 Eugene Kuleshov CLA 2007-10-17 15:32:58 EDT
"Add Attachment..."
Comment 7 Mik Kersten CLA 2007-10-18 17:39:26 EDT
Note that in the table the action is no longer called "Attach File" but "Add File...", since it is adding a file to the attachments of the bug.  How about we add the following to the editor's popup menu?

Attachments (group)
  Add File...
  Add Screenshot...
  
This way it will be consistent with the editor's actions.
Comment 8 Eugene Kuleshov CLA 2007-10-18 18:06:24 EDT
(In reply to comment #7)
> Note that in the table the action is no longer called "Attach File" but "Add
> File...", since it is adding a file to the attachments of the bug.  

It is adding an attachment, not a file. Though attachment can be created from a file. Note that Bugzilla web UI don't refer to a file in the corresponding action - "Add an attachment (proposed patch, testcase, etc.)".
Comment 9 Mik Kersten CLA 2007-10-18 22:56:19 EDT
Sigh, yes, the wording is a bit confusing in that sense.  Anyone have better suggestions?
Comment 10 Willian Mitsuda CLA 2007-10-18 23:23:19 EDT
What about simply "Attach..." and "Attach Screenshot..."?
Comment 11 Mik Kersten CLA 2007-10-25 23:36:07 EDT
 (In reply to comment #10)
> What about simply "Attach..." and "Attach Screenshot..."?

Agreed that this is the simplest.  Done.  Actions are are now in the Task Editor's context menu as well.
Comment 12 Mik Kersten CLA 2007-10-25 23:36:16 EDT
Created attachment 81227 [details]
mylyn/context/zip
Comment 13 Shawn Minto CLA 2007-10-30 13:57:05 EDT
I think that the image here is too dark and is distracting in the context menu full of muted icons.  Could you either create a different icon or mute the current one a bit so that it doesn't stand out so much?
Comment 14 Robert Elves CLA 2007-11-01 12:52:47 EDT
 (In reply to comment #13)
> I think that the image here is too dark and is distracting in the context menu
> full of muted icons.  Could you either create a different icon or mute the
> current one a bit so that it doesn't stand out so much?

+1 I've been noticing this lately myself.
Comment 15 Mik Kersten CLA 2007-11-01 14:26:43 EDT
Agreed.  I lightened the icon.