Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 205872

Summary: [JFace] ToolTip position wrong with multiple monitors
Product: [Eclipse Project] Platform Reporter: Steffen Pingel <steffen.pingel>
Component: UIAssignee: Thomas Schindl <tom.schindl>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse, mik.kersten, robert.elves, shawn.minto, snorthov, tom.schindl
Version: 3.3.1   
Target Milestone: 3.4 M4   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
fix
none
mylyn/context/zip none

Description Steffen Pingel CLA 2007-10-09 17:22:37 EDT
If the tooltip bounds are outside of the monitors bounds the location of the tooltip is miscalculated. See screenshots attached to bug 204903 .

(Possibly related: bug 202785)
Comment 1 Steffen Pingel CLA 2007-10-09 17:23:54 EDT
Created attachment 80005 [details]
fix
Comment 2 Steffen Pingel CLA 2007-10-09 17:23:59 EDT
Created attachment 80006 [details]
mylyn/context/zip
Comment 3 Thomas Schindl CLA 2007-10-12 05:11:33 EDT
Kim: I know that you have access to a 2 monitor setups could test and report if this works for one and 2 monitors?

Steffen: Is this only a Linux-GTK-Problem or also on other platforms (which seems to be the case when the algorithm is wrong).

Steve: To address the click through problem talked about in bug #204903 could you help me with Bug #195137. I'll try to create a test-case for OS-X, am I doing the right thing there to provide this click-through?
Comment 4 Steffen Pingel CLA 2007-10-12 11:21:24 EDT
(In reply to comment #3)
> Steffen: Is this only a Linux-GTK-Problem or also on other platforms (which
> seems to be the case when the algorithm is wrong).

I would assume that it happens on other platforms as well. I have only verified on Linux but this screenshot was taken on Mac OS X: https://bugs.eclipse.org/bugs/attachment.cgi?id=79977
Comment 5 Thomas Schindl CLA 2007-11-02 16:20:43 EDT
ping for Kim, could you please give the patch a try, as said I don't have access 2 dual monitor setup
Comment 6 Kim Horne CLA 2007-11-02 18:12:51 EDT
Ack!  I'm sorry Tom, I'm a horrible contributor - this totally fell off my radar.  I will check on Monday.
Comment 7 Thomas Schindl CLA 2007-11-02 18:20:32 EDT
never mind, marking for M4
Comment 8 Kim Horne CLA 2007-11-05 13:30:48 EST
Tom: is there a test case for this that doesn't involve installing Mylyn?
Comment 9 Thomas Schindl CLA 2007-11-05 14:29:50 EST
Well one of the snippets maybe?
Comment 10 Kim Horne CLA 2007-11-07 08:45:15 EST
Verified the bug and that the supplied fix works.
Comment 11 Thomas Schindl CLA 2007-11-07 09:00:10 EST
Thanks Kim - Released to CVS-HEAD > 20071107. Kim do you think we should consider this fix for 3.3.2, too?
Comment 12 Kim Horne CLA 2007-11-07 09:29:36 EST
I'd say no - it's annoying but doesn't cause any serious grief for the end user.
Comment 13 Thomas Schindl CLA 2007-11-07 09:34:59 EST
Steffen is the Mylyn-ToolTip change going to be part of 3.3.2 (if the yes we might have many complaints from Mylyn-Community when 3.3.2 is out of the doors) or targeted for 3.4?
Comment 14 Mik Kersten CLA 2007-11-07 14:47:41 EST
I have a weak +1 for considering this for 3.3.2.  Whether or not it gets merged Mylyn has to do a fix, beause the Task List relies very heavily on these tooltips, we have a large number of multi-monitor users, and when it happens it is very weird.  For Mylyn it's fine to copying the new class to do the fix, and I realize that Platform doesn't use these tooltips much.  But 3.3.2 will be around for a long time, this behavior is weird and hard for other integrators to diagnose, so if this is easy to get into 3.3.2 it could be worth it doing.
Comment 15 Steffen Pingel CLA 2007-11-07 14:53:51 EST
The Mylyn tooltip change will go out with the next Europa Winter Maintenance release. It seems that it is a straight forward fix that could easily be back-ported and will affect any plug-in using JFace ToolTips on Eclipse 3.3. It's also reproducible with the error log tooltips for instance.
Comment 16 Thomas Schindl CLA 2007-11-07 14:59:21 EST
CVS is a platform component that is using it see bug #195137.
Comment 17 Thomas Schindl CLA 2007-11-07 15:01:59 EST
I'm +1 for 3.3.2
Comment 18 Kim Horne CLA 2007-12-12 14:49:05 EST
Verified in I20071211-0010
Comment 19 Steffen Pingel CLA 2008-03-04 16:35:08 EST
*** Bug 221346 has been marked as a duplicate of this bug. ***