Bugzilla – Full Text Bug Listing
| Summary: | improve tooltip presentation and content | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> | ||||||||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||||||||
| Severity: | enhancement | ||||||||||||||
| Priority: | P3 | CC: | robert.elves, wmitsuda | ||||||||||||
| Version: | unspecified | Keywords: | plan | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Bug Depends on: | 186733, 189313, 197345, 207598, 207874, 210163, 210186, 211307, 217694, 220436, 226774, 234529, 234784, 238292, 255220, 276581, 283203 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Steffen Pingel
Request from bug 189313: Display the the task id in the tooltip so it matches the task list entry. remove square brackets from around values in the changes overview Need to defer to 2.3. For now I have removed the brackets from the incoming changes presentation and fixed a bug where the values in lists (e.g. changes of CCs) would not be separated by commas. From bug 189913 comment 26: [...] the task icon should be shown on first row and repo icon on the second, next to the repository Steffen: I think that we should remove the "Elapsed Time" line when the time is 00:00. At that point I belive that this adds more to the noise than to the useful information. - show first new comment (instead of the last one) and then show how many more unread comments are out there - strip quoted text when calculating comment text to be shown on tooltip - maybe strip comments that have only task context attachments - strip attachment header, or make it more concise, so it will be possible to see comment for that attachment - show reporter name (at least for new incoming tasks) - for new incoming tasks show beginning of description (same as it shown for new comments) "Assigned to" field is shown two times: with email and with full name and those entries aren't shown next to each other. - render JIRA due dates as dates and not as numbers Created attachment 85155 [details]
tooltip example
On this tooltip example you see that text is cut shorter then you could fit into the tooltip area. So, truncating algorithm should use the tooltip size in pixels and not cut text shorter than that if sreen real estate is available. Some of the system dialogs are using something like this to calculate dialog widths.
Also, it may make sense to move new comments below attributes (then attributes won't have to be idented) and maybe add a line break to separate comment author from the actual comment (right now text of the comment is shortened because of the author's email).
Added Due date info to the tooltip, just above the scheduled dates. Created attachment 90274 [details]
tooltip change comparator
What do you guys think of such comparator? The idea is to highligt changed part of the value, similar to what JUnit does in assertEqual()
I'm concerned that this is too much information for a tooltip and is hard to read quicikly in a purely textual form. (In reply to comment #12) > I'm concerned that this is too much information for a tooltip and is hard to > read quicikly in a purely textual form. Can you please elaborate how it is too much information for a tooltip? I didn't change amount of information shown there, I only changed the presentation and in result show less information, not more. I do see how it could be hard to read on a first glance, but please don't dismiss the idea too quick, because current tooltip is very hard to read, especially for the 1st and 3rd example shown my screenshot. I believe presentation can be greatly improved by using colored highlighting instead of "[...]" I've used for this prototype. Anyways, to see problem for yourself, add one more bug into the "depends on" list on bug 179254 from the web UI and then look what the current tooltip shows for the incoming changes. Same thing for the changed task summary. On a side note I think it wasn't a good idea to use the same code for tooltip and task notification details. Those things have very different boundaries from the screen real estate point of view and their UI can't be optimized at the same time. For example, your attempt to fit commenter name and the comment into a single line significantly reduced usefulness of tooltip, because with a long email address, unlike for the previous implementation, tooltip doesn't show much of the actual comment anymore. Personally I also would also like to see more then 2 attributes on the task tooltip as well as number of the new comments (as opposed to showing the last comment). I have another patch for the tooltip UI. Basically the idea is to show the first new comment instead of the last one and also strip comment lines starting from ">" from the shown text as well as some other decoration, such as "(In reply to comment #" and "Created an attachment (id=90274)". Would you be interested to take such patch? The idea is interesting but from a first glance I find the tooltip harder to read and the look very technical. This bug is scheduled for 3.1 and I generally don't plan on spending cycles reviewing or discussing patches before 3.0 is released unless there is indication from the community that this bug should be prioritized. I filed bug 220436 for generalizing the API. (In reply to comment #14) > I have another patch for the tooltip UI. Basically the idea is to show the first > new comment instead of the last one and also strip comment lines starting from > ">" from the shown text as well as some other decoration, such as "(In reply to > comment #" and "Created an attachment (id=90274)". > > Would you be interested to take such patch? I think it is more useful to show the most recent comment. Stripping quoted and generated text sounds like a good idea. If the patch is reasonably small and limited to that change only I would consider it. Please attach it to bug 186733. Rob mentioned another idea for presenting incoming changes. Show the new value with a different font style than the old value, e.g.: "Priority: P1 (P2)" where P2 is shown in a darker color similar to the new JDT label decorations. (In reply to comment #16) > Rob mentioned another idea for presenting incoming changes. Show the new value > with a different font style than the old value, e.g.: "Priority: P1 (P2)" where > P2 is shown in a darker color similar to the new JDT label decorations. I don't think there is an issue to see what changed with the short values like P1 and my patch is using threshold to skip those, but for longer values it is detecting changed fragments, e.g. newly added bug dependency or partially changed comments, because it is really hard to see what part of that long string actually been changed. Same idea is used in comparison editor, which can show not only changed string, but also highlights changes within strings. (In reply to comment #15) > I think it is more useful to show the most recent comment. Can you please elaborate why it is more useful ignore new comments and only see the last comment? Besides missing the beginning of discussion (which current tooltip UI seem encouraging), the last comment is often a dummy one with task context attachment. My original idea was actually to show the first new comment and then also show number of comments after it, but it don't fit too well with notification UI changes. BTW you may want to look at the Jazz UI overview, there are lots of great ideas to use. (In reply to comment #17) > BTW you may want to look at the Jazz UI overview, there are lots of great ideas to use. Jazz is a commercial tool with potential IP encumbrances. On Mylyn we should continue using our own ideas and user feedback to evolve our UIs. If anyone is drawing ideas from commercial tools when contributing patches please state that explicitly. For example, in the few cases where I have drawn on ideas from Microsoft Outlook and Windows Vista (both positive and negative) I have always made a point of listing these. Created attachment 110509 [details]
limit tooltip width
The tooltip messages now wrap at 600 pixels. This makes long error messages easier to read in the tooltip.
Fixed progress count showing for tasks with no subtasks. Steffen: You mentioned that you want to fix the message. Created attachment 123982 [details]
mylyn/context/zip
I have fixed the externalized strings. Created attachment 254613 [details]
that is koala
Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |