Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 205817

Summary:

[Wizards] Finish in Change ASCII/Binary does nothing if comment required

Product:

[Eclipse Project] Platform

Reporter:

Michael Valenta <Michael.Valenta>

Component:

CVS

Assignee:

Pawel Pogorzelski <pawel.pogorzelski1>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

Szymon.Brandys, tomasz.zarna

Version:

3.3

Keywords:

helpwanted

Target Milestone:

3.5 M1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch	pawel.pogorzelski1: iplog+

Description Michael Valenta

2007-10-09 10:29:28 EDT

I have configured my client to require that CVS commit comments be required. In the regular commit wizard, the Finish is disabled if the comment is empty. In the Chaneg ASCII/Binary wizard, the Finish button is enabled but does nothing if the comment is empty. It should be disabled and a message indicating that the comment is required should be displayed in the title area of the wizard.

Comment 1 Pawel Pogorzelski

2008-07-17 03:58:29 EDT

Created attachment 107702 [details]
Patch

Tomasz, could you have a look at it?

Comment 2 Tomasz Zarna

2008-07-17 07:00:09 EDT

Patch applied to HEAD with a minor modification (I inlined isAllowEmptyCommitComments method). Thanks Paul.