Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 205469

Summary:	[editor] add support for reverting changes before saving
Product:	z_Archived	Reporter:	Michael Scharf <eclipse>
Component:	Mylyn	Assignee:	Project Inbox <mylyn-triaged>
Status:	CLOSED MOVED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	angvoz.dev, sam.davis
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Michael Scharf

2007-10-04 12:47:34 EDT

When I edit a bugzilla task and I decide to trow away my changes, I have to
- Save the task (else the "Clear Outgoing" is not enabled)
- Do "Clear Outgoing" 

I think this workflow is very counter intuitive. Why do I have to save my changes to be able to undo them.
And why is a action that changes the content of my task in the  "Mark" meu.
I would expect an action next to Synchronize or File->Revert.

Comment 1 Eugene Kuleshov

2007-10-04 14:46:52 EDT

BTW, until changes are saved, task editors should support common Edit/Undo and File/Revert actions.

Comment 2 Mik Kersten

2007-10-04 20:24:26 EDT

 (In reply to comment #1)
> BTW, until changes are saved, task editors should support common Edit/Undo and
> File/Revert actions.

Created bug 205533 for that.

Comment 3 Mik Kersten

2008-02-12 17:13:39 EST

This is weird, but it is not incorrect given our editor lifecycle of:
1) open 
2) save 
3) submit 
4) close

The main request here is that we allow jumping between the pre-save state and open, which Eclipse supports via close, and we could consider supporting via Clear Outgoing.

Rob: the easy way to do this might be to ensure that File -> Revert works.

Comment 4 Eugene Kuleshov

2008-02-12 17:58:56 EST

(In reply to comment #3)
> The main request here is that we allow jumping between the pre-save state and
> open, which Eclipse supports via close, ...

That is not quite accurate. Platform textual editors allow to get back to the open state without closing. You can just "undo" all the changes with Ctrl-Z and editor will change state back to "unmodified".

Comment 5 Mik Kersten

2008-02-14 14:02:05 EST

Yes, I think this is the same state as "Revert" takes you too, and it is convenient that you can get there via Ctrl+Z for text editors.

Comment 6 Steffen Pingel

2010-10-28 12:23:23 EDT

*** Bug 328930 has been marked as a duplicate of this bug. ***

Comment 7 Andrew Gvozdev

2010-10-28 12:56:38 EDT

Is it possible to make "Clear Outgoing" button available right after editing started? It seems to do the right thing, see bug 328930.

Comment 8 Steffen Pingel

2011-01-28 14:58:40 EST

*** Bug 335730 has been marked as a duplicate of this bug. ***

Comment 9 Sam Davis

2011-01-28 18:51:51 EST

Repeating my thoughts from bug 335730:

When I start typing a comment and then decide not to submit it, I have to save the editor and then clear outgoing. If I just delete the comment, the editor is still marked as dirty, which means I later don't remember why it's dirty. One solution would be a button to discard the currently edited comment and clear the dirty state. Another would be to clear the dirty state if you just undo your typing. It would be nice to have both.

Comment 10 Eclipse Webmaster

2022-11-15 11:45:08 EST

Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn