Bugzilla – Full Text Bug Listing
| Summary: | [GlobalActions] Move "Uncategorized > Open File..." to "File > Open File..." | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Madhavi Balusu <madhavi.balusu> |
| Component: | UI | Assignee: | Paul Webster <pwebster> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | nboldt, pwebster, remy.suen |
| Version: | 3.3 | Keywords: | helpwanted |
| Target Milestone: | 3.4 M3 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Madhavi Balusu
Cntrl-O is currently used by JDT for Quick-Outline. File->Open File... isn't very common in Eclipse workflows. While its true that's the common accelerator, I think people would prefer keeping it bound to Quick-Outline by default. You can still set a binding for yourself from Window>Preferences>General>Keys You might have to go to the Advanced button and uncheck "filter uncategorized commands" PW Created attachment 79754 [details]
the Window>Preferences>General>Keys still does not show File->File Open when I unchecked "filter uncategorized commands"
It does not matter what the accelerator key is as long you provide an option to add one in Window>Preferences>General>Keys. It's glaringly being shown in File menu, what is the big secret being acheived by not allowing to bind an accelerator in Window>Preferences>General>Keys????!!!Does not make sense!!! It's not in the 'File' category but is in the 'Uncategorized' category. Type 'open f' in the filter text control below the 'Scheme' combo box and above the table and you'll find it. Thanks that worked. Thanks for your fast response. I am impressed. Created attachment 79756 [details]
Using Eclipse 3.3.0, I can't find it either... looks like it's not just unbound, it's unexposed.
Hi Nick, good catch. You also have to press the 'Advanced' button and then uncheck 'Filter uncategorized commands' in the subsequent dialog. Sorry about that, I have them unfiltered so I didn't include this step in comment #5. (In reply to comment #7) > Created an attachment (id=79756) [details] > Using Eclipse 3.3.0, I can't find it either... looks like it's not just > unbound, it's unexposed. Whoops, my bad... Advanced > [ ] Filter uncategorized commands Found it. ;-) But this brings up a usability question. Why isn't it categorized to match where it lives on the menu? If it's File > Open File... shouldn't it be categorized in the File category? Seems counterintuitive to a) not be categorized and b) have it hidden under the Advanced filters by default. Reopening and renaming to reflect actual problem. Here are the steps to bind an accelerator to File->Open File... 1. Open windows->Preferences->General->Keys 2. Make sure "Include unbound commands" is checked. 3. Click advanced and uncheck "filter uncategorized commands" (actually i unchecked all 3 of the check boxes there, but I don't think you have to). Type 4. Click 'open f' in the filter text control below the 'Scheme' combo box and above the table and you'll find it. Hope that helps. Madhavi: Yes, it's clearly doable. My point is that it's counterintuitive and sloppy to not be in File. But it sounds like this will be fixed with bug 186522, so I'll just link them together and hope that patch gets applied sooner rather than later. Renaming again to reflect the actual problem that's surfaced out of this discusssion. Nick, you are right! :-) OK, now that I've read to the end ... this is a platform action that should be represented by a command (and it's not). Open File needs a definitionId and matching command PW Created attachment 79766 [details]
Patch to add a commands extension.
It seems the action set already has a definitionId set so I just took that one.
Released to HEAD >20071022 PW in HEAD PW In I20071030-0010 PW |