Bugzilla – Full Text Bug Listing
| Summary: | API Recorder's Generate Test Suite dialog does not select a default selection. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Paul Slauenwhite <paulslau> | ||||||||
| Component: | TPTP | Assignee: | Tony Wang <newboya1988> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P1 | CC: | jkubasta | ||||||||
| Version: | unspecified | Keywords: | plan | ||||||||
| Target Milestone: | --- | Flags: | paulslau:
review-
|
||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
(In reply to comment #0) > I really wish the dialog for generating a testsuite pre selected the > > "testsuite" option not the "no testsuite" option, the only reason for > > using it is to generate a testsuite in thefirst place. > Source: http://dev.eclipse.org/newslists/news.eclipse.tptp/msg04794.html There is no default selection since the dialog is reused. Included in 4.5 plan for the Test Tools project. Created attachment 90674 [details]
Changes to defect 205093
Created attachment 90773 [details]
Whole Changes in defect 205093
Hi Paul, please review this patch 'Whoel Changes in defect 205093' Thanks! Hi Paul, please review this patch 'Whole Changes in defect 205093' Thanks! Comment on attachment 90674 [details]
Changes to defect 205093
obsolete patch
Patch reviewed. A couple of comments: -When creating patches for review, ensure only modified code is included to make the review process easier. For example, does not generate a patch for a class that has whitespace changes, unless they are meaningful to the code changes. -Instead of reusing org.eclipse.tptp.test.tools.api.internal.ui.test.generation.TPTPJUnitTestSuiteGenerationPane.java, I suggest to extending the class. -New classes should contain the following copyright statement: /********************************************************************** * Copyright (c) 2008 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/epl-v10.html * $Id$ * * Contributors: * IBM - Initial API and implementation **********************************************************************/ See http://www.eclipse.org/tptp/home/documents/process/development/copyright.html. -Please make sure you add the copyright statement to each new file with the year set to 2008. -Please make sure the copyright end date is updated on each modified file to 2008. -Please make sure author and version tags are added to the class JavaDoc comments for each new/modified file. For example: @author Tony Wang @version February 28, 2008 -Commented code code should not be included in patches unless required in the future. -There is one place where an import is never used and needs to be removed. Created attachment 90992 [details]
Patch Version 2
Tony, please see the changes I made to your original patch.
Patch Version 2 checked into CVS (HEAD). Verified in TPTP-4.5.0RC3-200806031051. Closing. |
I really wish the dialog for generating a testsuite pre selected the > "testsuite" option not the "no testsuite" option, the only reason for > using it is to generate a testsuite in thefirst place.