Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 204471

Summary: Sort by severity in Preferences Page cannot change between ascending and descending
Product: z_Archived Reporter: Liz Dancy <lizdancy>
Component: TPTPAssignee: Alex Nan <apnan>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: apnan, jkubasta, labadie
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Attachments:
Description Flags
Patch file none

Description Liz Dancy CLA 2007-09-24 12:02:06 EDT 
Using the Windows > Preferences > Profiling and Logging > Log View > Sort Records Preference Page, first select only severity and then the radio button ascending > Apply. The sort is preformed successfully.

Now open the dialog again and change it to descending > Apply. The change is not applied but the log view is refreshed.

The workaround is to use the column header sorting from the Log View. However, the effect of refreshing the Log View could be misleading because it looks like the records are being re-sorted. This could confuse a user who wants to see the reverse sorting by severity, particularly in a large log file.
Comment 1 Alex Nan CLA 2008-01-08 15:15:07 EST 
Gotoh-san, please take a look.
Comment 2 Yasuhisa Gotoh CLA 2008-01-15 05:49:41 EST 
This problem also occurs when trying to sort the log records in the log view using the "Sort Columns" dialog which is shown from the context menu or the toolbar.
Comment 3 Yasuhisa Gotoh CLA 2008-01-15 07:05:27 EST 
Created attachment 86929 [details]
Patch file

Alex, here is the patch.  Please review.
Comment 4 Alex Nan CLA 2008-01-16 22:44:14 EST 
Gotoh-san I think the idea here was that the refresh on the log viewer is performed only if the sort criteria has changed and this condition seems to have been commented out by somebody and introduced a regression. Your fix works but is not optimal.
Comment 5 Alex Nan CLA 2008-02-01 19:29:24 EST 
Simplified the fix. Needed to comment two lines of code in org.eclipse.tptp.platform.log.views.internal.views.LogPage.
The fix doesn't include any optimization, after investigating the problem concluded that the effort is too high to include it in this defect.
Comment 6 Paul Slauenwhite CLA 2009-06-30 10:30:30 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.