Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 203403

Summary: Update to Apache HttpClient 3.1
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Steffen Pingel <steffen.pingel>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P1 CC: caniszczyk, mjmeijer, nhapke
Version: unspecified   
Target Milestone: 2.3   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
mylyn/context/zip
none
Gzip/mod_deflate log files with HttpClient 3.1 none

Description Steffen Pingel CLA 2007-09-14 01:14:06 EDT
The new version of HttpClient allows the use of "sticky" HostConfigurations even with absolute URLs that are used by Axis. Registering a global protocol handler in WebClientUtil.setupHttpClient() would not be necessary anymore:

https://issues.apache.org/jira/browse/HTTPCLIENT-634
Comment 1 Mik Kersten CLA 2007-09-14 22:55:09 EDT
+1

Steffen: are you interested in taking this one on?
Comment 2 Mik Kersten CLA 2007-09-14 22:55:44 EDT
Note that I'll have to do the IP approval process first.
Comment 3 Steffen Pingel CLA 2007-09-15 00:39:42 EDT
Do you know if there are any plans to make Apache HttpClient 3.1 available through Orbit? Otherwise I don't think there will be enough benefit in upgrading to make this a priority.
Comment 4 Steffen Pingel CLA 2007-09-18 00:48:13 EDT
We might actually need this to fix bug 197853. Mik, if this is not a major pain could you kick of the IP review process?
Comment 6 Mik Kersten CLA 2007-10-11 20:21:07 EDT
This is now under review.
Comment 7 maarten meijer CLA 2007-11-06 12:07:42 EST
I propose to facade the whole HttpClient library as well, so that add ons such as
gzip encoding the traffic (bug 196056) and a proper User Agent string (bug 205213) can roll into all connectors.
Comment 8 Mik Kersten CLA 2007-11-15 01:31:31 EST
Steffen: should I try to see if we can get this for 2.2?  
Comment 9 Steffen Pingel CLA 2007-11-15 02:01:22 EST
Considering other priorities I don't think we would be able to integrate the new version in time for 2.2. Doing this early in the 2.3 cycle would be good though.
Comment 10 Mik Kersten CLA 2007-12-05 21:13:25 EST
Steffen: the CQ has been approved, so we can proceed with this once it gets priority.
Comment 11 Steffen Pingel CLA 2007-12-05 21:37:09 EST
Great! I'll take a look at it when 2.2 is out the door.
Comment 12 Steffen Pingel CLA 2008-01-02 05:45:01 EST
Replaced Apache Commons HttpClient version  3.0.2 by version 3.1in CVS. 
Comment 13 Steffen Pingel CLA 2008-01-02 05:45:06 EST
Created attachment 85985 [details]
mylyn/context/zip
Comment 14 Eugene Kuleshov CLA 2008-01-02 11:11:02 EST
I am confused. I thought that the current strategy is to move everything into orbit.

Also assignee is invalid.
Comment 15 Steffen Pingel CLA 2008-01-02 13:24:38 EST
As you pointed out on a another bug, moving to Orbit will require changes in the distribution and build process. Updating HttpClient was blocking other bugs with higher priority therefore I resolved this bug first. The bug was assigned to Mik which is perfectly valid.
Comment 16 Eugene Kuleshov CLA 2008-01-02 14:35:10 EST
Makes sense, but can you please resolve bug 208073 as it been contributed? Then build and other issues related to moving to orbit can be resolved on a separate bug report.

As per bug assignment, can you please clarify what you're referred as valid? You did the work, hence bug should be assigned to you as per project policy, unless I am missing something.
Comment 17 maarten meijer CLA 2008-01-04 04:59:51 EST
 (In reply to comment #12)
> Replaced Apache Commons HttpClient version  3.0.2 by version 3.1in CVS.
My agent string returns: "Mylyn/2.3.0 Eclipse/3.3.1 (null) HttpClient/3.1 Java/1.5.0_13 (Apple) Mac OS X/10.5.1 (i386; en_US)"
and I find the gzip encoding, bug 205708 , continues to work for the bugzilla connector even though no unit tests exist for that.
Attached some log file output
Comment 18 maarten meijer CLA 2008-01-04 05:01:46 EST
Created attachment 86161 [details]
Gzip/mod_deflate log files with HttpClient 3.1