Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 203270

Summary: Problems with qualifier substitution and bundle look-up
Product: [Eclipse Project] PDE Reporter: DJ Houghton <dj.houghton>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: aniefer, any, david_williams
Version: 3.4   
Target Milestone: 3.6 M3   
Hardware: All   
OS: All   
Whiteboard:

Description DJ Houghton CLA 2007-09-13 10:25:11 EDT
build i0904

When looking up a qualifier version in the PDEState, PDE/Build is returning a version (micro >= the requested version) which results in the wrong version being selected if there is more than one bundle with the same major/minor.

For instance, if you have bundles 3.6.0.foo and 3.6.1.foo and in the feature we have plug-in inclusions of 3.6.0.qualifier and 3.6.1.qualifier. When we do the look-up we are getting the same 3.6.1.foo bundle for both bundle look-ups.

Also we need to review this code because we return the first bundle which satisfies the constraints, rather than gathering all the results and returning the greatest version.
Comment 1 DJ Houghton CLA 2007-09-13 13:01:06 EDT
I should note that this caused us grief in the Orbit builds. As a work-around we put specific version numbers in the feature.xml file and it worked fine.
Comment 2 Andrew Niefer CLA 2009-09-11 17:01:12 EDT
I believe we fixed the micro version selection in 3.4

I have now changed things to select the highest version when there is more than one resolved bundle.
Comment 3 Andrew Niefer CLA 2009-09-25 11:47:36 EDT
The fix released in 3.6M2 only fixed feature inclusions like "1.2.3.qualifier".  I have now also fixed inclusions of just "0.0.0"