Bugzilla – Full Text Bug Listing
| Summary: | [DataBinding] Add tests for IObservable.dispose() to conformance tests | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Brad Reynolds <bradleyjames> |
| Component: | UI | Assignee: | Brad Reynolds <bradleyjames> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | bokowski |
| Version: | 3.4 | ||
| Target Milestone: | 3.4 M3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Brad Reynolds
FIXED > 20071006 Added a new test to ObservableContractTest. It's going to be hard for this to be 100% correct. I have to dispose the observable and then invoke delegate.change(observable). The problem is that if the delegate isn't implemented to change the observed object, the observable might throw an exception. I've updated the javadoc for IObservableContractDelegate.change(IObservable) stating that if possible the change needs to occur on the observed object. The test wraps the call in a try catch to avoid receiving exceptions for delegates that can't invoke a change on the observed object. There's a better way to handle this... (In reply to comment #1) > Added a new test to ObservableContractTest. It's going to be hard for this to > be 100% correct. I have to dispose the observable and then invoke > delegate.change(observable). The problem is that if the delegate isn't > implemented to change the observed object, the observable might throw an > exception. I've updated the javadoc for > IObservableContractDelegate.change(IObservable) stating that if possible the > change needs to occur on the observed object. The test wraps the call in a try > catch to avoid receiving exceptions for delegates that can't invoke a change on > the observed object. > FIXED > 20071006 There's no need to catch an exception. The test now just creates a new observable and invokes a change on it. The disposed observable should not receive an event when this occurs. VERIFIED in I20071031-1800. |