Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 202631

Summary: Java SampleClient blocks AC launching
Product: z_Archived Reporter: Igor Alelekov <igor.alelekov>
Component: TPTPAssignee: Jonathan West <jgwest>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P2 CC: jgwest, jkubasta, kiryl.kazakevich, paulslau, xubing
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard: housecleaned460 closed460
Attachments:
Description Flags
Patch none

Description Igor Alelekov CLA 2007-09-07 10:01:00 EDT
Build ID: 200709060100

Steps To Reproduce:
1.start AC
2.start Java SampleClient
3.shutdown AC

TimeCollector remains active and blocks next AC launching

More information:
This issue is repeatable on Linux and Windows
Comment 1 Samson Wai CLA 2007-09-11 09:44:28 EDT
Reset sizing.
Comment 2 Samson Wai CLA 2007-11-27 09:30:38 EST
Hi Bing. I have transferred my bugs to you for triage. Thanks.
Comment 3 Bing Xu CLA 2008-01-18 14:21:33 EST
Igor, I need bit more information.  This is what I did.

1. In one cmd window, start ACServer
2. In another cmd window, start SampleClient
3. In 3rd cmd window, do 'ACServer -shutdown'

Then the first ACServer is terminated and I can start ACServer again.   Did I miss any steps?

Comment 4 Igor Alelekov CLA 2008-01-21 04:18:28 EST
Hi Bing,
SampleClient works good. I had the problem with JavaSampleClient, first of all on Linux.
Comment 5 Bing Xu CLA 2008-01-22 12:08:06 EST
Igor,

I tried the following on my XP and couldn't reproduce the bug:

1. In cmd window, start ACServer
2. In Eclipse, run SampleClientAC.java as Java Application
3. When SampleClientAC is done, in another cmd window, do 'ACServer -shutdown'
4. Start ACServer again
5. Run SampleClientAC again 
6. When SampleClientAC is done, do 'ACServer -shutdown' again.

I've tried both TPTP-4.4.1-200709101254 and TPTP-4.5.0-200712211700 with IBM 1.5 JVM.  AC security is off.

What's your environment?
Comment 6 Igor Alelekov CLA 2008-01-23 02:02:25 EST
(In reply to comment #5)
> Igor,
> I tried the following on my XP and couldn't reproduce the bug:
> 1. In cmd window, start ACServer
> 2. In Eclipse, run SampleClientAC.java as Java Application
> 3. When SampleClientAC is done, in another cmd window, do 'ACServer -shutdown'
> 4. Start ACServer again
> 5. Run SampleClientAC again 
> 6. When SampleClientAC is done, do 'ACServer -shutdown' again.
> I've tried both TPTP-4.4.1-200709101254 and TPTP-4.5.0-200712211700 with IBM
> 1.5 JVM.  AC security is off.
> What's your environment?

Bing, could you try your use case on Linux? I'm using RHEL 4 upd 3.
Comment 7 Bing Xu CLA 2008-01-24 14:37:53 EST
Hi Igor,

I tried this again on Linux SUSE with TPTP 4.5, SUN JVM 1.5 and it worked for me.  I had to modify the agent.xml for TimeCollector because of bug 213630. 

I don't have access to a RedHat 4 on Linux 32 now.

Have you tried this with 4.5?
Comment 8 Igor Alelekov CLA 2008-01-25 01:29:00 EST
(In reply to comment #7)
> Have you tried this with 4.5?

Hi Bing,
Yes, this issue is reproducible on my RHEL with last TPTP 4.5 build.
Comment 9 Bing Xu CLA 2008-02-12 17:09:15 EST
Created attachment 89565 [details]
Patch

Reproduced the bug on RedHat running on Linux EM64T with IBM JVM 1.5 and TPTP-4.5.0-200802100400.

Test patch on XP and Linux EM64T RedHat.

Igor, can you review the patch.  Thanks.
Comment 10 Igor Alelekov CLA 2008-02-13 02:36:47 EST
Bing, it seems this is defect of AC.
AC should terminate all processes it lanched.
Comment 11 Bing Xu CLA 2008-02-13 09:37:09 EST
Hi Jonathan, can you review the patch.  Thanks.
Comment 12 Bing Xu CLA 2008-02-13 11:54:11 EST
Jonathan, can you take a look at the native side to see if AC needs fix to terminate the processes.   

My change was adding a ICollector.releaseAccess() call.  From the comment in the code I can't tell if it is mandatory for me to do this.
Comment 13 jkubasta CLA 2008-05-14 11:23:25 EDT
Jonathan, Is this containable in 4.5.0?
Comment 14 jkubasta CLA 2008-05-23 09:03:20 EDT
Deferral to future with PMC approval
Comment 15 Kathy Chan CLA 2009-02-23 13:41:28 EST
Mass update of P1 enhancements and defects targetted to future to P2.
Comment 16 Paul Slauenwhite CLA 2009-06-30 09:23:48 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX by the Project Lead since this originator of this defect has an inactive Bugzilla account and it may be no longer relevant. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 17 Paul Slauenwhite CLA 2009-06-30 09:59:11 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.