Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 202510

Summary: [registers] Make IRegisters interface more generic.
Product: [Tools] CDT Reporter: Pawel Piech <pawel.1.piech>
Component: cdt-debug-dsfAssignee: Randy Rohrbach <Randy.Rohrbach>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cdtdoug, Randy.Rohrbach
Version: 0 DD 1.0   
Target Milestone: DD 1.0   
Hardware: PC   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 159693    
Attachments:
Description Flags
Patch with fix. cdtdoug: iplog-

Description Pawel Piech CLA 2007-09-06 14:55:54 EDT 
Register groups do not change based on the currently selected stack frame or even thread.  So two register groups that are created with different frame contexts should still be equal.  The implication of this change is that the getRegisters() method should take two arguments:  IRegisterGroupDMContext and a generic IDMContext<?>, where the generic context could be a frame, thread, etc.

This bug resulted from discussion in bug 159693.
Comment 1 Pawel Piech CLA 2007-09-06 14:57:11 EDT 
Randy, I'm assigning this bug to you so you can make the API change and simultaneously update the MI service as well as the WR debugger service implementations.
Comment 2 Pawel Piech CLA 2007-11-30 15:41:12 EST 
Hi Veenu,
I believe you are already working on this.  Could you mark this bug as fixed when you work out a solution.
Comment 3 Pawel Piech CLA 2008-03-28 14:19:21 EDT 
The problem in bug description is no longer relevant.  IRegiers.getRegisters() takes a generic IDMContext as an argument.  If a client needs to pass multiple independent contexts to the method, it can use a CompositeDMContext for this purpose.  However I did find that getBitFields() takes the strongly-typed IRegisterDMContext as an argument and this seems like an unnecessary restriction.
Comment 4 Pawel Piech CLA 2008-03-28 14:21:06 EDT 
Created attachment 94027 [details]
Patch with fix.
Comment 5 Pawel Piech CLA 2008-03-28 14:22:27 EDT 
I committed the change which makes the IRunControl.getBitFields() take a generic IDMContext argument.

Randy please verify.
Comment 6 Pawel Piech CLA 2008-05-12 19:17:30 EDT 
Re-opening to assign for verify.
Comment 7 Pawel Piech CLA 2008-05-12 19:18:10 EDT 
Marking back as fixed.
Randy please review the change.
Comment 8 Pawel Piech CLA 2008-08-13 13:06:31 EDT 
Closing out 1.0 bugs.