Bugzilla – Full Text Bug Listing
| Summary: | [Navigation] "Previous change" button doesn't work properly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Krzysztof Michalski <krzysztof.michalski> | ||||
| Component: | Compare | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | malgorzata.tomczyk, marek.chodorowski, Michael.Valenta, sptaszkiewicz, Szymon.Brandys, tomasz.zarna | ||||
| Version: | 3.4 | Keywords: | helpwanted | ||||
| Target Milestone: | 4.3 | Flags: | malgorzata.tomczyk:
review+
|
||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 383796, 383797, 406348 | ||||||
| Attachments: |
|
||||||
|
Description
Krzysztof Michalski
Affirmative, it looks like clicking "Previous Change" does the same thing as "Previous Difference". The only difference is that it selects a part of text/file. I would mark it as a valid bug. Let's make it a 'helpwanted' bug. I will also lower the priority to the value appropriate for this kind of issues. Hello. I would like to throw some light on this problem and clarify especially Krzysztof's 2nd step. To illustrate how it currently works and how I believe it should work consider the 10 line file below where Cn indicates a change. 01 02 C1 03 04 C2 05 C3 06 C4 07 08 C5 09 C6 10 Starting at the top if you repeatedly click the NextChange icon the following will occur NextChange -> Line 02 highlighted (Difference 1) NextChange -> change C1 highlighted NextChange -> Lines 04, 05 and 06 highlighted (Difference 2) NextChange -> change C2 highlighted NextChange -> change C3 highlighted NextChange -> change C4 highlighted NextChange -> Lines 08 and 09 highlighted (Difference 3) NextChange -> change C5 highlighted NextChange -> change C6 highlighted NextChange -> prompt to start from the top (if enabled) Now if you start from the bottom and click PreviousChange you would expect the sequence to be reversed, that is the last difference should be highlighted, then each change in the diferences selected in reverse order then the previous difference, etc. However, what you will see happen is: PreviousChange -> Difference 3 highlighted PreviousChange -> change C6 highlighted PreviousChange -> Difference 2 highlighted PreviousChange -> change C4 highlighted PreviousChange -> Difference 1 highlighted PreviousChange -> change C1 highlighted My questions are: 1) Are you agree that this is right behavior? 2) Do you know if there are any plans to fix this bug in the near future? Created attachment 215172 [details]
patch v0.1
(In reply to comment #4) > Created attachment 215172 [details] > patch v0.1 Thanks for the patch Marek! Could you please push it to Gerrit[1]. Also a unit test would be great. You can use SWTBot [2] if it's going to be a UI test, we can then add it to our unofficial (for the time being) UI suite[3]. [1] https://git.eclipse.org/r/#/ [2] http://www.eclipse.org/swtbot/ [3] https://github.com/zaza/org.eclipse.compare.tests.ui Gosia, could you please have a look at the provided patch? Is it any good? Pushed to Gerrit: https://git.eclipse.org/r/6541 I reviewed the patch and it's good. There was an error in calculating if the current change is first in the difference and the patch fixes it. I think it's fine to merge it. Fixed with 89abaa6f5d2de889ac809d81d969409130d2f0ba |