Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 2023

Summary:

No banner graphics in Save As dialog (1GDKM9Y)

Product:

[Eclipse Project] Platform

Reporter:

Simon Arsenault <simon_arsenault>

Component:

Assignee:

Randy Giffen <Randy_Giffen>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

lynne_kues

Version:

2.0

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
picture of Save As dialog	none
patch file	none
full image file	none
basic image file	none

Description Simon Arsenault

2001-10-10 22:24:45 EDT

Open an editor on a file
	Select File->Save As... menu item
	Notice the dialog has a white banner at the top with
	nothing in it. It that the expected look?

NOTES:
	RG (5/11/01 2:46:25 PM)
	See 1GD0BXF: ITPUI:ALL - File save as dialog banner area empty

NE (05/28/01 11:14:07 AM)
	Need to be consistent.

Comment 1 DJ Houghton

2001-10-29 17:46:12 EST

PRODUCT VERSION:
	0.105

Comment 2 Lynne Kues

2002-01-10 12:52:51 EST

Created attachment 210 [details]
picture of Save As dialog

Comment 3 Lynne Kues

2002-01-10 18:12:32 EST

Created attachment of Save As dialog.  Inconsistencies as follows:

- dialog has a banner gif without an icon ==> use same gif as for create new 
file
- dialog uses "..." in it's titles ==> get rid of ... in labels
- dialog does not have explanation text like other wizards ==> add an 
explanation

Comment 4 Lynne Kues

2002-01-11 12:37:19 EST

Created attachment 212 [details]
patch file

Comment 5 Lynne Kues

2002-01-11 12:39:01 EST

Patch file doesn't appear to pick up new resource files.  Including new image 
files as attachments.  These files go under /icons/full/wizban and 
/icons/basic/wizban.

Comment 6 Lynne Kues

2002-01-11 12:43:46 EST

Created attachment 215 [details]
full image file

Comment 7 Lynne Kues

2002-01-11 12:44:06 EST

Created attachment 216 [details]
basic image file

Comment 8 Lynne Kues

2002-01-16 16:24:45 EST

Waiting on RG to review.  Reassigning to him.

Comment 9 Randy Giffen

2002-01-17 12:08:28 EST

Reviewed and released the changes

I made the following change to the method comment in SelectionDialog to
follow the JavaDoc pattern we use when overriding methods.

/** 
 * The <code>SaveAsDialog</code> iplementation of this <code>Window</code>
 * method disposes of the banner image when the dialog is closed.
 */
public boolean close() {
	if (dlgTitleImage != null) 
		dlgTitleImage.dispose();
	return super.close();
}