Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 201866

Summary: [Wizards] Cut and copy text to clipboard is broken in CVS commit wizard
Product: [Eclipse Project] Platform Reporter: Sebastian H. <sebastian.haberey>
Component: CVSAssignee: Tomasz Zarna <tomasz.zarna>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: eclipse, markus.kell.r, Szymon.Brandys, tomasz.zarna
Version: 3.4   
Target Milestone: 3.4 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard: hasPatch
Attachments:
Description Flags
Patch
none
mylyn/context/zip none

Description Sebastian H. CLA 2007-08-31 04:13:20 EDT 
Build ID: I20070809-1105

Steps To Reproduce:
1. Commit any change to cvs.
2. In the CVS commit wizzard enter a CVS comment.
3a. Higlight the comment and right-click it. The context-menu-items "Copy" and "Cut" are greyed out.

or

3b. Press Ctrl+C (or Ctrl+X) and paste the text in an external text editor. Clipboard doesn't contain the text.


More information:
Comment 1 Tomasz Zarna CLA 2007-10-09 09:58:23 EDT 
WORKSFORME in N20071008-0010.
Comment 2 Szymon Brandys CLA 2007-10-09 09:58:51 EDT 
WORKSFORME
Comment 3 Sebastian H. CLA 2007-10-17 10:11:02 EDT 
I think I didn't describe it accurately enough. Sorry.

1. Commit any change to cvs.
2. In the CVS commit wizzard enter a CVS comment.
3. Press Ctrl+A to select the whole comment.
4. Press Ctrl+X to cut the selection to the clipboard.

Step 4 doesn't work for me, i.e. the text won't disappear and it is not copied to the clipboard. I tested it with Eclipse 3.4 M2 and it won't work there either.
Comment 4 Tomasz Zarna CLA 2007-10-18 11:51:38 EDT 
Oh, now I can see that too. The "Cut" action is not even enabled in the context menu if you did the "Select all" before. I'm not sure whether the "Cut" and "Copy" actions are not updated after doing "Select all" or the "Select all" is not executed completely (i.e. the selection is not properly set), but it's definitely a bug. We will need to look for the real cause. 

Thank for pointing that out Sebastian.
Comment 5 Tomasz Zarna CLA 2007-11-06 13:05:05 EST 
*** Bug 208918 has been marked as a duplicate of this bug. ***
Comment 6 Tomasz Zarna CLA 2007-11-09 05:19:58 EST 
The Cut/Copy pair doesn't work in New/Edit Change Set dialogs as they are using CommitCommentArea too.
Comment 7 Tomasz Zarna CLA 2007-11-09 09:46:52 EST 
Created attachment 82539 [details]
Patch

I've replaced selection listener for the text field with one for the text viewer. Now,  we are notified when the selection has changed after clicking "Select All".
Comment 8 Tomasz Zarna CLA 2007-11-09 09:46:55 EST 
Created attachment 82540 [details]
mylyn/context/zip
Comment 9 Tomasz Zarna CLA 2007-11-09 11:43:17 EST 
Patch released to HEAD.
Comment 10 Tomasz Zarna CLA 2007-11-14 08:32:26 EST 
*** Bug 209693 has been marked as a duplicate of this bug. ***
Comment 11 Tomasz Zarna CLA 2007-12-11 10:10:06 EST 
Verified in N20071202-0010 for both the Commit Wizard and Change Set dialogs.