Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 201602

Summary:	[JFace] Equivalent of NameValuePairDialog
Product:	[Eclipse Project] Platform	Reporter:	Sandrine Soudant <soudant>
Component:	UI	Assignee:	Susan McCourt <susan>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P5	CC:	bokowski, remy.suen
Version:	3.3	Keywords:	helpwanted
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Sandrine Soudant

2007-08-29 12:16:33 EDT

The class org.eclipse.jdt.internal.debug.ui.launcher.NameValuePairDialog provides a dialog box with a title, two text areas and their labels. It is convenient to interact with user to ask pair values but using a class from an internal package is bad.

Have you an equivalent in a public package ?

Best regards,

Comment 1 Boris Bokowski

2007-09-04 11:13:05 EDT

Not that I know of.

Comment 2 Boris Bokowski

2007-09-20 10:11:31 EDT

Susan, please correct me if you don't agree, but I don't think it is likely that we will have the time/resources to make this API.  I haven't seen other requests for this functionality, so it doesn't look like a lot of clients would benefit.

Sandrine, the situation would be different if you contributed a patch and test cases and signed up for any maintenance work that would be required.

How about you copy the code into your own plug-in and maintain it yourself?  To avoid licensing problems, you could create a "dumping ground" plug-in for useful stuff which is licensed under the EPL.

Comment 3 Susan McCourt

2007-09-20 11:17:55 EDT

I looked at this yesterday, and honestly I don't see that we would ever make this API.  (Even if contributed and tested).

The dialog's purpose is to collect two text values with minimal validation (non-blank strings).  As soon as it would become API, we'd get requests to assign an IInputValidator (per field?), why not take an array of name/value pairs, etc. etc.  Since the function is so simple to implement on your own, I agree that a copy is the way to go, that way you can evolve it for your needs.