Bug 201470

Description Stefan Fleiter 2007-08-28 15:54:28 EDT

All shell scripts specify /bin/sh in their http://en.wikipedia.org/wiki/Shebang_%28Unix%29 line.
As stated at wikipedia

#!/bin/sh — On some systems, such as Solaris, this is the Bourne shell. On Linux systems there is usually no Bourne shell and this is a link to another shell, such as bash. According to the Single UNIX Specification's requirements for /bin/sh, such a shell will usually mimic the Bourne shell's behaviour, but be aware that using #!/bin/sh in shell scripts may invoke different Bourne-compatible shells on different systems.

So you can not expect the shell to be bash.
But this is expected in several places.

ubuntu 7.04 and up use /bin/dash - Debian Almquist SHell.
dash requires the shell script to be POSIX compliant, while bash is less
strict and supports the '==' operator for string comparison.

All the following problems are distributed over all shell files.
There is a lot of duplication there ACStart.sh, ACVersion.sh and all the
other shell files are duplicated for all architectures.
So these bugs all have to be fixed several times.


String comparisons habe to be done with =, not ==.
Not all shells can compare empty strings from variables correctly,
so use
    if [ x$VAR = x ]; then
to work around this.
Or even better
use
    if [ -z x$VAR ]; then


For ACServer.sh, ACStop.sh and ACVersion.sh the following changes should be done:


@@ -6,8 +6,8 @@
 #
 # If TPTP_AC_HOME is not set then we assume we are running from bin.
 #
-if [ "$TPTP_AC_HOME" = "" ]; then
-       TPTP_AC_HOME=..
+if [  -z $TPTP_AC_HOME ]; then
+       TPTP_AC_HOME=$(dirname $0)/..
        export TPTP_AC_HOME
 fi


Instead of relying on the fact the script is executed from the bin dir
use "$(dirname $0)/.." to get the parent dir of the script no matter what
the current working dir is.

 PATH=$TPTP_AC_HOME/bin:$PATH
@@ -41,7 +41,7 @@
 # Bug 175696
 # Make sure TEMP dir is set
 #
-if [ x$TEMP == x ]; then
+if [ -z $TEMP ]; then
        export TEMP=/tmp
 fi


SetConfig.sh has other problems:
It is not clear from which directory this has to be called.
java is called from the path. What if I have several java versions installed?
config.nl1.jar, config.nl2.jar and config.nl2a.jar are not part of tptp.
    if [ $SECURED = "0" ]; then  
This could fail if SECURED could be the empty string.