Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 200320

Summary: [ThreadProf] Add contention analyses features to TPTP Profiler
Product: z_Archived Reporter: Alexander N. Alexeev <analexee>
Component: TPTPAssignee: Alexander N. Alexeev <analexee>
Status: CLOSED WONTFIX QA Contact:
Severity: enhancement    
Priority: P2 CC: analexee, chris.l.elford, ewchan, jkubasta, Mikhail.Voronin, paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
URL: http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_200320.html
Whiteboard: closed471
Bug Depends on: 200341, 200342, 209724, 209725, 209727, 209728, 219442    
Bug Blocks:    

Description Alexander N. Alexeev CLA 2007-08-17 04:57:12 EDT
Contention for monitors may significantly affect overall performance of application. Some set of functions required in TPTP for identifying problem monitors with high contention rate and to evaluate impact of such contention on performance. 
 
Initiate function list:
- gather and depict statistics for monitors (hold/free time, min/max/average waiting time)
- depict most critical monitors for distinct threads
- mark hot locks
- construct critical path
Comment 1 Chris Elford CLA 2007-10-03 17:11:53 EDT
I can't do it since I'm not a committer and I am not the submitter.  Can you modify this bug and set "depends on" 200342 and 200341.

Thx
Comment 2 Alexander N. Alexeev CLA 2007-10-04 05:54:18 EDT
Add dependencies.   
Comment 3 Paul Slauenwhite CLA 2007-10-21 21:01:10 EDT
Approved by the AG for TPTP 4.5 with the following comments:

-Requires usability review after design is complete.  With this amount of data, there is always concern with UI clutter and confusion.
-Test sizing is too low.
-What heuristics would be used to approximate the critical path at run-time?
-In Pic. 5, why are there checkboxes?  
-In Pic. 6, what does the 'A' and 'L' buttons do of the four things listed? 
-In Pic. 7, should thread group be added?  Also, each column should be sortable.
-The Event Specification for Java profiling (http://www.eclipse.org/tptp/platform/documents/resources/profilingspec/XML4Profiling.htm) will need to be updated and reviewed for the additional profiling events (including their binary counterparts for 196713).
-Have 200341 and 200342 been changed to dependant defects (e.g. work items)?
Comment 4 Alexander N. Alexeev CLA 2007-10-25 12:47:31 EDT
> -Requires usability review after design is complete.  With this amount of data,
> there is always concern with UI clutter and confusion.
What are retirements for GUI design, how it should be formed, what details should  include that usability review makes sense? 

> -Test sizing is too low.
we can increase up to 2pw
 
> -What heuristics would be used to approximate the critical path at run-time?
Complex heuristic is a stretch goal, it is mainly required for monitoring. Before that for constructing CP at runtime list of events is considered as it contains "threadEnd" event after the last event in the list.

> -In Pic. 5, why are there checkboxes?  
Checkboxes are required for choosing subset of threads and investigate cumulative statistic for them.  

> -In Pic. 6, what does the 'A' and 'L' buttons do of the four things listed? 
Actually four buttons should be on panel one for each type for interaction, two was depicted as sample 

> -In Pic. 7, should thread group be added?  Also, each column should be
> sortable.
Ok, I will add it in conjunction with more detailed GUI design.

> (including their binary counterparts for 196713).
196713 will be updated.

> -Have 200341 and 200342 been changed to dependant defects (e.g. work items)?
Question isn't clear. If you mean Bugzilla , yes, this defect depends on 200341 200342

Comment 5 Paul Slauenwhite CLA 2008-01-17 10:02:40 EST
(In reply to comment #4)

Sorry for such a late reply.

> > -Requires usability review after design is complete.  With this amount of data,
> > there is always concern with UI clutter and confusion.
> What are retirements for GUI design, how it should be formed, what details
> should  include that usability review makes sense? 

We follow the Eclipse UI Guidlines (http://wiki.eclipse.org/index.php/User_Interface_Guidelines).  Once the implementation is complete, you can demo the function on an AG call and we can have an usability review on the call.

> > -Test sizing is too low.
> we can increase up to 2pw

Done.

> > -Have 200341 and 200342 been changed to dependant defects (e.g. work items)?
> Question isn't clear. If you mean Bugzilla , yes, this defect depends on 200341
> 200342
 
That is what I meant.

Comment 6 Alexander N. Alexeev CLA 2008-02-01 08:51:57 EST
Design description updated.
Please, take a look on it and provide feedback.

Thanks,
Alex.
Comment 7 Paul Slauenwhite CLA 2008-02-05 08:49:27 EST
(In reply to comment #6)
> Design description updated.
> Please, take a look on it and provide feedback.
> 
> Thanks,
> Alex.
> 

Thanks Alex.  Here are some comments:

-In Pic. 5, the check boxes should only be rows containing threads.  That is, there should not be a check box for the heading of the table.  I would consider adding these check boxes in to the table as a separate column (like Pic. 7).  

-Please make the request (via Eugene) to the IBM Graphics Team for the required graphics (e.g. icons) so we can check-in the graphics before our UI freese (in preparation for our UI freeze on Apr. 4). 

-In Pic. 7, should thread group be added?  Also, each column should be sortable.

Eugene, can you also review this new document?
Comment 8 Alexander N. Alexeev CLA 2008-02-21 07:31:45 EST
> -In Pic. 5, the check boxes should only be rows containing threads.  That is,
> there should not be a check box for the heading of the table.  I would consider
> adding these check boxes in to the table as a separate column (like Pic. 7).  

Thanks you for note. I've revisited this view, multiselect table is enough for provided functionality. 
I've update document.

> -Please make the request (via Eugene) to the IBM Graphics Team for the required
> graphics (e.g. icons) so we can check-in the graphics before our UI freese (in
> preparation for our UI freeze on Apr. 4). 
Done. Eugene track it on IBM site

> -In Pic. 7, should thread group be added?  Also, each column should be
> sortable.
I agree about column sorting.
Group usage for filtering can be considered as extension and included later.


Comment 9 jkubasta CLA 2008-05-23 08:42:41 EDT
Deferral to future with PMC approval
Comment 10 Kathy Chan CLA 2009-02-23 13:41:19 EST
Mass update of P1 enhancements and defects targetted to future to P2.
Comment 11 Paul Slauenwhite CLA 2009-06-30 06:37:26 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As such, TPTP is not delivering enhancements. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement is resolved as WONTFIX. For this enhancement to be considered, please re-open with an attached patch including the Description Document (see http://www.eclipse.org/tptp/home/documents/process/development/description_documents.html), code (see http://www.eclipse.org/tptp/home/documents/resources/TPTPDevGuide.htm), and test cases (see http://www.eclipse.org/tptp/home/documents/process/TPTP_Testing_Strategy.html).
Comment 12 Paul Slauenwhite CLA 2009-06-30 06:38:11 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As such, TPTP is not delivering enhancements. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement is resolved as WONTFIX. For this enhancement to be considered, please re-open with an attached patch including the Description Document (see http://www.eclipse.org/tptp/home/documents/process/development/description_documents.html), code (see http://www.eclipse.org/tptp/home/documents/resources/TPTPDevGuide.htm), and test cases (see http://www.eclipse.org/tptp/home/documents/process/TPTP_Testing_Strategy.html).
Comment 13 Kathy Chan CLA 2010-11-18 18:54:19 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.