Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 200209

Summary: Using fully qualified host name to import a local log invokes remote import
Product: z_Archived Reporter: Jane Fang <janefang>
Component: TPTPAssignee: Bing Xu <xubing>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: ewchan, jkubasta, samwai
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Attachments:
Description Flags
Patch file with updated org.eclipse.hyades.security.internal.util.BaseConnectUtil() none

Description Jane Fang CLA 2007-08-16 12:05:03 EDT
Eclipse Build ID: I20070625-1500

Steps To Reproduce:
1. open log import wizard to import a local log
2. create a new host with the fully qualified name of the local host. I used blueloon.torolab.ibm.com in my case
3. select the newly created host and click OK to import

If no RAC is installed on the local machine, import will fail.


More information:
Comment 1 Jane Fang CLA 2007-08-16 16:05:28 EDT
I debugged a bit and found the following:

When use the statement below to create a node, Node.getName() doesnot return the fully qualified host name. In my case, it returns "blueloon". 
     Node lnode = NodeFactory.createNode("localhost");

However, if use the fully qualified name of the local host, say, "blueloon.torolab.ibm.com" to create a node, Node.getName() returns "blueloon.torolab.ibm.com".

If this is a problem in NodeFactory, please advise which component this defect should be against and i will make the change.


Comment 2 Eugene Chan CLA 2007-08-16 17:44:36 EDT
Joanna, would you please take a look at the problem in the NodeFactory.
Comment 3 Bing Xu CLA 2007-10-22 16:06:39 EDT
I tried in 4.5 and when entered full hostname like 'bing.torolab.ibm.com' in the 
Comment 4 Bing Xu CLA 2007-10-22 16:12:22 EDT
Created attachment 80904 [details]
Patch file with updated org.eclipse.hyades.security.internal.util.BaseConnectUtil()

updated org.eclipse.hyades.security.internal.util.BaseConnectUtil().
Comment 5 Bing Xu CLA 2007-10-22 16:14:55 EDT
I tried to import a Log File using 4.5 code.  If I entered full hostname (bing.torolab.ibm.com) in the 'Host Name' tab, then the 'Browse...' button is disabled in the 'Details' tab so I couldn't select the file to import.  

Problem is with org.eclipse.hyades.security.internal.util.BaseConnectUtil.isLocalHost() method. 
It returns False when given the full hostname.

Samson, please review the fix.  Thanks.
Comment 6 jkubasta CLA 2007-10-23 10:02:48 EDT
For tracking purposes, leaving bug assigned to Bing but adding Samson to the cc list.  Thx.
Comment 7 Samson Wai CLA 2007-11-28 14:46:20 EST
The patch looks good.
Comment 8 jkubasta CLA 2008-01-09 09:19:33 EST
Patch committed to Head
Comment 9 Paul Slauenwhite CLA 2009-06-30 12:09:47 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.