Bugzilla – Full Text Bug Listing
| Summary: | [api] support spell checking and hyperlink detection in the source editor of the Wiki Page Editor | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Xiaoyang Guan <xbugzilla> | ||||||||||
| Component: | Mylyn | Assignee: | Xiaoyang Guan <xbugzilla> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P3 | CC: | robert.elves, steffen.pingel | ||||||||||
| Version: | unspecified | ||||||||||||
| Target Milestone: | 2.1 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Xiaoyang Guan
I don't see why we can move it into tasks.ui. I imagine we should have a better way of contributing rules to the RepositoryTextScanner though. Steffen what are your thoughts on this? that scanner thing need to be replaced with something that would use hyperlink detectors instead... Is the only purpose of RepositoryTextScanner to provide syntax highlighting for hyperlinks? It seems that we need to add a way for connectors to contribute rules if that is the case, optimally based on the existing hyperlink detectors as Eugene suggested. I don't see any reason not to make RepositoryViewerConfig public API though (the class should probably be renamed to TaskSourceViewerConfiguration or something like that). What is the use case for making RepositoryViewerConfig API? currently it is only used internally by the TaskFormPage. It's needed for the wiki editor. (In reply to comment #3) > Is the only purpose of RepositoryTextScanner to provide syntax highlighting for > hyperlinks? It seems that we need to add a way for connectors to contribute > rules if that is the case, optimally based on the existing hyperlink detectors > as Eugene suggested. Agreed, at the moment it is a hard coded mess. > I don't see any reason not to make RepositoryViewerConfig public API though (the > class should probably be renamed to TaskSourceViewerConfiguration or something > like that). How about TaskTextViewerConfiguration? > Agreed, at the moment it is a hard coded mess. I opened bug 200613. > How about TaskTextViewerConfiguration? Sounds good. Created attachment 76576 [details]
add spell checking and hyperlinking to Wiki page editor
This patch uses RepositoryViewerConfig, which should be replaced with the TaskTextViewerConfiguration as discussed above once it becomes public API.
Created attachment 76577 [details]
mylyn/context/zip
Created attachment 76588 [details]
make RepositoryViewerConfig public API and rename to TaskTextViewerConfig
Rob, please apply.
Created attachment 76589 [details]
mylyn/context/zip
Rob, please apply my patch and I'll refactor Xiaoyang's patch for the new API. Xiaoyang, I'll assign all tasks to you that you have contributed to. It's the Mylyn way of recognizing contributions and earning responsibility. (In reply to comment #12) > Xiaoyang, I'll assign all tasks to you that you have contributed to. It's the > Mylyn way of recognizing contributions and earning responsibility. Sure, and if you prefer, I could do the refactoring and update the patch. (In reply to comment #12) > Rob, please apply my patch and I'll refactor Xiaoyang's patch for the new API. Patch applied. Committed spell checking and hyperlinking support to new wiki plug-in in CVS. |