Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 199607

Summary: Help for New ... Test/Test Attributes panel cannot be found
Product: z_Archived Reporter: Charles Doebler <cdoebler>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED INVALID QA Contact:
Severity: normal    
Priority: P1 CC: alexberns
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 200586    
Attachments:
Description Flags
screenshot of missing help none

Description Charles Doebler CLA 2007-08-10 12:24:33 EDT
Build ID: RPT 7.0.1

Steps To Reproduce:
1. Click New > Other > SIP Test > Test Attributes.
2. Click ?.



More information:
I was told by the SIP developer that this wizard panel is not specific to RPT or the SIP extension and that is part of the TPTP code
Comment 1 Paul Slauenwhite CLA 2007-08-23 06:52:02 EDT
TPTP Test does not have any Test Attributes help or wizard page (e.g. to disable the CSH).  If you feel this is still a defect, please reopen and provide a file name for the missing help file.
Comment 2 Charles Doebler CLA 2007-08-23 08:05:44 EDT
Created attachment 76760 [details]
screenshot of missing help

I just added a screenshot of the panel.
Comment 3 Charles Doebler CLA 2007-08-23 08:07:47 EDT
added a screenshot of the missing help
Comment 4 Paul Slauenwhite CLA 2007-08-23 08:25:54 EDT
This panel is not part of TPTP.
Comment 5 Charles Doebler CLA 2007-08-23 08:36:53 EDT
I'll pass this back to the RPT dev team. They originally passed it back to me saying that the panel wasn't part of RPT. I love running in a circle.
Comment 6 Alex Bernstein CLA 2007-08-23 09:05:47 EDT
This panel IS in fact TPTP. It is called AttributeWizardPage and produced by TestSuiteNewWizard2 which we extend to create RPT test assets.
Comment 7 Paul Slauenwhite CLA 2007-08-23 13:45:30 EDT
(In reply to comment #6)
> This panel IS in fact TPTP. It is called AttributeWizardPage and produced by
> TestSuiteNewWizard2 which we extend to create RPT test assets.
> 

Yes, AttributeWizardPage is a generic Wizard page that is part of the TPTP Platform project and a reference is held by the super class of TestSuiteNewWizard2 (HyadesNewWizard).  However, this Wizard page does not have CSH.  The CSH is added by the extender of TestSuiteNewWizard2, an abstract of class, by over-ridding the org.eclipse.hyades.ui.internal.wizard.HyadesWizard.setPageHelpIds() method.  The Wizard in the consuming product is probably over-ridding the org.eclipse.hyades.ui.internal.wizard.HyadesWizard.setPageHelpIds() method and setting an incorrect CSH ID. 
Comment 8 Alex Bernstein CLA 2007-08-23 14:53:28 EDT
Our product extends the wizard and adds couple of more pages in addition to LocationPage and AttributeWizardPage. I have not noticed anywhere that we call org.eclipse.hyades.ui.internal.wizard.HyadesWizard.setPageHelpIds(). Therefore it must be using whatever help ID it gets on the Hyades layer.

Is it a requirement that this method must be called client code such as RPT?

For my own curiosity I checked some other Wizards that seem to have the Attribute page (e.g. New Datapool Wizard). They do not produce context-sensitive help for that page either.
Comment 9 Paul Slauenwhite CLA 2007-08-24 08:59:23 EDT
(In reply to comment #8)
> Our product extends the wizard and adds couple of more pages in addition to
> LocationPage and AttributeWizardPage. I have not noticed anywhere that we call
> org.eclipse.hyades.ui.internal.wizard.HyadesWizard.setPageHelpIds(). Therefore
> it must be using whatever help ID it gets on the Hyades layer.

I believe your product overrides setPageHelpIds() method for one of your wizards.  See Joe T. for details.

> Is it a requirement that this method must be called client code such as RPT?

No.  This is logical place to hook in CSH for extensions. 

> For my own curiosity I checked some other Wizards that seem to have the
> Attribute page (e.g. New Datapool Wizard). They do not produce
> context-sensitive help for that page either.
 
I confirmed that TPTP does not provide CSH for this page.  However, we will reexamine the whole CSH issue in TPTP under 200586.

Comment 10 Alex Bernstein CLA 2007-08-24 09:12:35 EDT
RPT has only one wizard where this method is extended. This bugzilla is not about that wizard/class.

What, if anything, is the default help ID for Attribute page?
Comment 11 Paul Slauenwhite CLA 2007-08-24 15:12:03 EDT
(In reply to comment #10)
> RPT has only one wizard where this method is extended. This bugzilla is not
> about that wizard/class.
> 
> What, if anything, is the default help ID for Attribute page?
> 

Again, we do not even have the strings for the Attribute page in our resource bundles, so we are not setting the CSH ID.