Bugzilla – Full Text Bug Listing
| Summary: | Agent Controller preferences are scattered over Profiling and Logging preferences section | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Valentina Popescu <popescu> | ||||||||||
| Component: | TPTP | Assignee: | Ritwik Lodhiya <ritwikl> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P1 | CC: | ewchan, igor.alelekov, jkubasta, samwai | ||||||||||
| Version: | unspecified | Keywords: | plan | ||||||||||
| Target Milestone: | --- | Flags: | ewchan:
review-
|
||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | closed460 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Valentina Popescu
Ritwik, please have a go at resolving this defect I agree with Valentina that the "Host" tab should be moved under the "Agent Controller" section. However, the "Agent Controller local port" currently under "Profiling and Logging" section should be removed instead of moved under "Agent Controller". The port value of localhost in the "Host" tab should be consumed instead in replace of the "Agent Controller local port" value. Created attachment 91403 [details]
Proposed Patch
The Hosts tab is now moved under the Agent Controller Section and the "Agent Controller local port: ---- " option is removed from the Profiling and Logging Page (now it can only be modified from the Hosts Tab).
Ritwik, preference value of CommonUIConstants.LOCALHOST_PORT is used in the following place and you have removed its setting in org.eclipse.hyades.trace.ui.internal.preferences.TraceBasePreferencePage, please make sure you migrate the value retrieval code with the new value in Host tab. AgentAvailibilityTester.java - org.eclipse.tptp.platform.jvmti.client/src/org/eclipse/tptp/platform/jvmti/client/internal/launcher AgentHandler.java - org.eclipse.tptp.platform.agentcontroller/src-native-new/test/CompatibilityTest/DumpAgentHandler/src/SampleAgentHandler AttachConfigurationDetail.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/util AttachDelegate.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/launcher CommonUITracePlugin.java - org.eclipse.tptp.platform.common.ui.trace/src/org/eclipse/tptp/platform/common/ui/trace/internal ICommonConstants.java - org.eclipse.tptp.platform.common/src/org/eclipse/tptp/platform/common/internal (2 matches) LauncherUtility.java - org.eclipse.hyades.trace.ui/src/org/eclipse/tptp/trace/ui/internal/launcher/core PIDelegateHelper.java - org.eclipse.hyades.trace.ui/src/org/eclipse/tptp/trace/ui/internal/launcher/deleg/application ProfileHostTab.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/launcher ProfileJavaApplicationDelegate.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/launcher ProfileOnServerAdapter.java - org.eclipse.tptp.platform.profile.server.core/src/org/eclipse/tptp/platform/profile/server/core/internal TIAttachLauncherDelegate.java - org.eclipse.tptp.platform.jvmti.client/src/org/eclipse/tptp/platform/jvmti/client/internal/launcher TraceBasePreferencePage.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/preferences TraceProfileUI.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/core UIPlugin.java - org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui reviewed, -1 , please see my comment #4. Created attachment 91581 [details]
Patch #2
This patch moves the "Agent Controller local port:" section under Agent Controller page.
References to the LOCALHOST key have been updated. =)
Ritwik,
In /org.eclipse.tptp.platform.common.ui.trace/plugin.xml
<!-- The host preference page -->
<extension point="org.eclipse.ui.preferencePages">
<page
name="%P_NODEP"
category="org.eclipse.hyades.security.internal.preference.ACPreferencePage"
class="org.eclipse.hyades.trace.ui.internal.preferences.HostPreferencePage"
id="org.eclipse.hyades.trace.ui.internal.preferences.HostPreferencePage">
</page>
</extension>
category="org.eclipse.hyades.security.internal.preference.ACPreferencePage" is declared in /org.eclipse.hyades.ui/plugin.xml which is not in the dependencies list of org.eclipse.tptp.platform.common.ui.trace. The declaration of category should be moved to common.ui.trace instead.
Created attachment 92181 [details]
Patch #2.5
I have moved the ACPreferencePage down into the common.ui.trace and updatedall its references. The LOCALHOST_PORT default initialization is now in CommonUIPlugin.
Please rereview to see if this one is better :)
Created attachment 92194 [details]
Patch 2.5.2
Please diregard the previous patch. The previous patch doesnot update all the references to the LOCALHOST_PORT. This one does everything as the above patches and updates the refereces and copyrights.
(In reply to comment #9) > Created an attachment (id=92194) [details] > Patch 2.5.2 > > Please diregard the previous patch. The previous patch doesnot update all the > references to the LOCALHOST_PORT. This one does everything as the above patches > and updates the refereces and copyrights. > Patch reviewed and submitted to HEAD. Nice Job Ritwik! Resolving as fixed As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |