Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 198067

Summary: Adopt Phoenix banner in Planet Eclipse
Product: z_Archived Reporter: Gunnar Wagenknecht <gunnar>
Component: PlanetEclipseAssignee: Gunnar Wagenknecht <gunnar>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P3 CC: caniszczyk, denis.roy, ian.skerrett, loskutov, nathan, phoenix.ui-inbox
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 197520    
Bug Blocks: 178877    
Attachments:
Description Flags
B&W rss icon none

Description Gunnar Wagenknecht CLA 2007-07-27 01:22:16 EDT
Eclipse.org has new banners (bug 197520). Nathan specially created one for Planet Eclipse. We should incorporate the banner into Planet Eclipse. That may require switching to the Phoenix skin.
Comment 1 Chris Aniszczyk CLA 2007-08-05 17:04:27 EDT
Nathan, do you want to create a new top banner for the Planet, similar to how we have sexy ones for EclipseLive, etc...?
Comment 2 Nathan Gervais CLA 2007-08-06 10:17:06 EDT
I've got all the images and CSS for the Planet Eclipse Header.   Whats the path for the PlanetEclipse source in CVS so i can see what im working with.
Comment 4 Gunnar Wagenknecht CLA 2007-08-06 10:23:58 EDT
Nathan, you can also setup the viewer locally on your machine. You need SSH access to dev.eclipse.org. Log on and grab everything (including generated content) from /home/apps/planet/output/ and sub dirs (you don't need the faces).
Comment 5 Gunnar Wagenknecht CLA 2007-09-29 13:14:59 EDT
Banner adopted.
http://planeteclipse.org/planet-new/
Comment 6 Denis Roy CLA 2007-10-01 08:41:05 EDT
Looks good.  Can we remove the little separator bar in front of the about link?
Comment 7 Gunnar Wagenknecht CLA 2007-10-01 09:19:51 EDT
(In reply to comment #6)
> Looks good.  Can we remove the little separator bar in front of the about link?

Fixed.
Comment 8 Chris Aniszczyk CLA 2007-10-01 09:52:24 EDT
Gunnar, do you think it's time to move to planet-new? It looks good to me.
Comment 9 Denis Roy CLA 2007-10-01 09:59:52 EDT
Created attachment 79478 [details]
B&W rss icon

The link color is great, but it's the same as the visited link.  How about putting a grayscale RSS feed icon next to inactive feeds?
Comment 10 Gunnar Wagenknecht CLA 2007-10-01 10:13:11 EDT
we need at least one +1 and no -1 on every effected bug (bug 198067, bug 195734 and bug 204295)
Comment 11 Nathan Gervais CLA 2007-10-01 10:23:20 EDT
+1 for the B&W Icon and the new phoenix style skin
Comment 12 Denis Roy CLA 2007-10-01 15:19:32 EDT
+1
Comment 13 Gunnar Wagenknecht CLA 2007-10-02 02:25:46 EDT
changes published to live planet
http://planeteclipse.org/planet/
Comment 14 Gunnar Wagenknecht CLA 2007-10-10 02:24:25 EDT
I had to back out the changes for now because of bug 205844.
Comment 15 Denis Roy CLA 2007-10-10 11:27:41 EDT
planet-new doesn't render in MSIE with the new banners.  What can we do to solve this?

I've tried finding a JavaScript debugger for MSIE without too much success, and I must be honest, the JS code on Planet has me a bit perplexed.
Comment 16 Gunnar Wagenknecht CLA 2007-10-11 03:50:05 EDT
(In reply to comment #15)
> I've tried finding a JavaScript debugger for MSIE without too much success, and
> I must be honest, the JS code on Planet has me a bit perplexed.

The JavaScript is generated. I think that a bug in GWT 1.4.60 (the latest compiler) is causing this. They generate platform specific JavaScript for each browser. I've opened a bug with the GWT team to analyze the problem.

However, I think it's time for a different approach on feed loading. I'll work on this.
Comment 17 Gunnar Wagenknecht CLA 2007-10-16 06:10:31 EDT
Guys, I've implemented a rework to the Planet Eclipse viewer. It no longer loads the main feed asynchronously in the background upon the first load. Instead, it simply "hooks" into the existing content. 

This has some advantages as it eliminates the first terraforming. The experience for browsers without JavaScript is also better. As a result of this, the JavaScript should now be disabled for IE < 7.

I'd appreciate if you could have a quick look and help in testing the site.

http://planeteclipse.org/planet-new/
Comment 18 Denis Roy CLA 2007-10-16 06:42:26 EDT
Thanks, Gunnar.

On Linux x86_64, FF 2.0.0.7 and Konqueror 3.4.2 work like a charm.  I'll test the Windows browsers too when I get in the office.
Comment 19 Denis Roy CLA 2007-10-16 08:54:41 EDT
On Win32, FF 2.0.0.7 and Safari 3.0.3 do just fine.

MSIE 6 renders the page only briefly, then all the middle content disappears.  The scollbar still allows me to scroll vertically through the void of white.
Comment 20 Gunnar Wagenknecht CLA 2007-11-06 05:18:08 EST
*** Bug 208811 has been marked as a duplicate of this bug. ***
Comment 21 Ian Skerrett CLA 2008-01-29 16:23:35 EST
What can we do to kick start this process for having Planet Eclipse use the new banner.  It would be really nice to have PlanetEclipse be consistent with the other web sites.
Comment 22 Gunnar Wagenknecht CLA 2008-01-30 08:38:07 EST
(In reply to comment #21)
> What can we do to kick start this process for having Planet Eclipse use the new
> banner.  

Ian, thanks for getting involved. The banner is already implemented on our test site based on bug 209188.

http://planeteclipse.org/planet-new/

We need to make sure that it works in all browser. Actually, it's IE <= 6 which is causing us the trouble. Sometimes a wide blog post screws up the layout. I appreciate any help/feedback in this areay.

Other than that, we can start the voting for this one and bug 209188 to get it released. :)

Comment 23 Gunnar Wagenknecht CLA 2008-05-05 05:43:15 EDT

*** This bug has been marked as a duplicate of bug 229919 ***