Bug 197958

Description Thomas Brandon 2007-07-26 09:00:13 EDT

Build ID: I20070625-1500

Steps To Reproduce:
Add a hyperlink in TextConsoleViewer on a line with an existing style provided by the document partitioner.

More information:
The attached plugin demonstrates the issue. Open the TextConsoleViewer Error->Sample View. A TextConsoleViewer is displayed with 4 lines each containing a hyperlink.
On the first line, with no styles display is correct.
On the second line where there is a style for the label, but no style for the hyperlink the hyperlink style is not applied. The hyperlink is there and works but is not styled.
On the third line a style is added to the label and a dummy style applied to the hyperlink. Here the hyperlink is correctly styled.
On the fourth line a style is provided for label and hyperlink but the same style is used for the hyperlink across multiple calls to the partitioners getStyleRanges method. Here the hyperlink initially displays correctly but when the TextConsoleViewer is redrawn (as occurs when you mouse over the hyperlink) the styling dissapears.
The issue is in the override method of TextConsoleViewer, called from lineGetStyle. If there are no styles specified for the line then this method correctly adds a new style for the hyperlink. If there are styles for the line the method removes the hyperlink from these styles' ranges and adds a new style. However in the case where there are ranges but none of them overlap the hyperlink no style is added for the hyperlink.
As this method modifies the ranges provided by the partitioner if ranges are shared across multiple calls to getStyledRanges then the first redraw removes the hyperlink from these ranges and on subsequent redraws there is no style for the hyperlinks range so it is not styled.