Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 197551

Summary:	[regression]New File dialog not dismissed when create new file inside a .zip
Product:	[Tools] Target Management	Reporter:	Xuan Chen <xuanchen>
Component:	RSE	Assignee:	dsdp.tm.rse-inbox <tm.rse-inbox>
Status:	CLOSED DUPLICATE	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	normal
Priority:	P3
Version:	2.0
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Xuan Chen

2007-07-23 17:22:55 EDT

Right click on a zip file in a dstore linux connection(dummy.zip), and choose New -> File to bring up the New File dialog.
Enter a new name, and click Finish button (or just press Enter).  I could see the file is added into the zip file, but the New File dialog is not dismissed.
And the following error is added to error log (see below).  
I encountered this problem using 0723 RSE integrated driver.
But could not reproduce this problem using 0713 driver (with the same DStore linux server, which is 0723 server)

No problem when creating a new file inside a zip file in Local Windows connection.

java.lang.NullPointerException
	at org.eclipse.rse.internal.ui.view.SystemViewLabelAndContentProvider.hasChildren(SystemViewLabelAndContentProvider.java:393)
	at org.eclipse.rse.internal.ui.view.SystemView.isExpandable(SystemView.java:5969)
	at org.eclipse.jface.viewers.AbstractTreeViewer.isExpandable(AbstractTreeViewer.java:2044)
	at org.eclipse.jface.viewers.AbstractTreeViewer.updateChildren(AbstractTreeViewer.java:2466)
	at org.eclipse.jface.viewers.AbstractTreeViewer.updateChildren(AbstractTreeViewer.java:2438)
	at org.eclipse.rse.internal.ui.view.SystemView.internalRSERefreshStruct(SystemView.java:3140)
	at org.eclipse.rse.internal.ui.view.SystemView.internalRSERefreshStruct(SystemView.java:3151)
	at org.eclipse.rse.internal.ui.view.SystemView.internalRefreshStruct(SystemView.java:3124)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalRefresh(AbstractTreeViewer.java:1801)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalRefresh(AbstractTreeViewer.java:1757)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalRefresh(AbstractTreeViewer.java:1743)
	at org.eclipse.rse.internal.ui.view.SystemView.doOurInternalRefresh(SystemView.java:3113)
	at org.eclipse.rse.internal.ui.view.SystemView.ourInternalRefresh(SystemView.java:3062)
	at org.eclipse.rse.internal.ui.view.SystemView.smartRefresh(SystemView.java:3426)
	at org.eclipse.rse.internal.ui.view.SystemView.smartRefresh(SystemView.java:3390)
	at org.eclipse.rse.internal.ui.view.SystemView.refreshRemoteObject(SystemView.java:2978)
	at org.eclipse.rse.internal.ui.view.SystemView.systemRemoteResourceChanged(SystemView.java:2383)
	at org.eclipse.rse.internal.core.model.SystemRemoteChangeEventManager.notify(SystemRemoteChangeEventManager.java:69)
	at org.eclipse.rse.ui.internal.model.SystemRegistry.fireRemoteResourceChangeEvent(SystemRegistry.java:2770)
	at org.eclipse.rse.internal.files.ui.wizards.SystemNewFileWizard.updateGUI(SystemNewFileWizard.java:299)
	at org.eclipse.rse.internal.files.ui.wizards.SystemNewFileWizard.performFinish(SystemNewFileWizard.java:199)
	at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:742)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:373)
	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:616)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:227)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
	at org.eclipse.jface.window.Window.open(Window.java:796)
	at org.eclipse.rse.ui.actions.SystemBaseDialogAction.run(SystemBaseDialogAction.java:299)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:545)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
	at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:504)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:443)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1169)


-----------Enter bugs above this line-----------
TM 2.0.1 Testing
installation : eclipse-platform-3.3RC3 
RSE install  : RSE-SDK-I20070723-1200.zip
java.runtime : Sun 1.5.0_06-b05
os.name:     : Windows XP 5.1, Service Pack 2
------------------------------------------------
systemtype   : Linux - DStore

Comment 1 Martin Oberhuber

2007-07-23 18:29:41 EDT


*** This bug has been marked as a duplicate of bug 197550 ***

Comment 2 Xuan Chen

2007-07-24 00:54:21 EDT

I got the new I20070723-1930 driver and tried, and still got this problem.

Comment 3 Martin Oberhuber

2007-07-24 01:20:18 EDT

Hm. Did you also still see the exception? - It's unlikely that the same exception would still occur.

Perhaps you got the exception in the log yesterday for a different reason, and the issue with the dialog is a different one.

Comment 4 Martin Oberhuber

2007-07-24 08:12:02 EDT

The problem was that my fix had been checked in but somehow not released properly. I released it again to I20070424-0730 and verified that it works OK in the actual I-build.

Comment 5 Xuan Chen

2007-07-24 12:09:45 EDT

Verified using I20070424-0730 driver.