Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 196956

Summary: Deadlock detection doesn't work at Thread Analysis
Product: z_Archived Reporter: Alexander N. Alexeev <analexee>
Component: TPTPAssignee: Alexander N. Alexeev <analexee>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P1 CC: analexee, ewchan, sluiman
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: closed460
Attachments:
Description Flags
Application with deadlock
none
Patch
none
Test application none

Description Alexander N. Alexeev CLA 2007-07-18 09:19:41 EDT
Try to profile deadlocked application (attached) with Thread analysis
It should mark deadlocked threads and time moment. 

Seems that problem lays at event loading analysis.
Comment 1 Alexander N. Alexeev CLA 2007-07-18 09:21:17 EDT
Created attachment 74046 [details]
Application with deadlock
Comment 2 Eugene Chan CLA 2007-07-31 23:48:44 EDT
This sounds major/critical to me.
Comment 3 Harm Sluiman CLA 2007-08-01 08:25:50 EDT
If the problem is as large as the description, this does seem like a stop ship defect.
Comment 4 Guru Nagarajan CLA 2007-08-01 09:32:15 EDT
This is an enh. to leverage the Model capabilities to enable deadlock detection. When the 4.5 stream is open this will be requested as a candidate.
Comment 5 Alexander N. Alexeev CLA 2007-11-04 17:36:23 EST
Seems problem is in the model (Loader of monContendedEnter event)
All deadlock analysis is doing during "monContendedEnter" event loading, but
even for simplest application it isn't able to detect deadlock.
JVMTI agent sends all required events with appropriated data.
   
Can we change component to "Platform.model"?

I've spent some time for investigation and propose a patch.
Harm, please, take a look on it.

Thanks, Alex.

Comment 6 Alexander N. Alexeev CLA 2007-11-04 17:40:46 EST
Created attachment 82062 [details]
Patch
Comment 7 Alexander N. Alexeev CLA 2007-11-04 17:43:46 EST
Created attachment 82063 [details]
Test application
Comment 8 Harm Sluiman CLA 2007-11-05 13:59:14 EST
(In reply to comment #5)
> Seems problem is in the model (Loader of monContendedEnter event)
> All deadlock analysis is doing during "monContendedEnter" event loading, but
> even for simplest application it isn't able to detect deadlock.
> JVMTI agent sends all required events with appropriated data.
> 
> Can we change component to "Platform.model"?
> 
> I've spent some time for investigation and propose a patch.
> Harm, please, take a look on it.
> 
> Thanks, Alex.
> 

I will get to this asap
Comment 9 Eugene Chan CLA 2007-11-14 15:10:25 EST
Patch in Comment #6 is submitted to HEAD (4.5).
Comment 10 Paul Slauenwhite CLA 2007-12-19 07:58:59 EST
Please change the target to the 4.5 iteration when this Bugzilla was resolved.
Comment 11 Paul Slauenwhite CLA 2009-06-30 13:26:22 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 12 Paul Slauenwhite CLA 2009-06-30 13:47:54 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.