Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 196435

Summary: Eliminate jvm activation on AC startup
Product: z_Archived Reporter: Igor Alelekov <igor.alelekov>
Component: TPTPAssignee: Igor Alelekov <igor.alelekov>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: chris.l.elford, guru.nagarajan, jkubasta, kiryl.kazakevich, paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: All   
URL: http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_196435.html
Whiteboard: closed460
Attachments:
Description Flags
patch
none
Feature Description Document
none
updated patch none

Description Igor Alelekov CLA 2007-07-13 05:49:38 EDT
Currently, with AC startup a JVM is also started in Backward Compatibility Layer to provide file server service for old RAC clients.

Measurement of virtual memory on IA-32 machines for the last AC 4.4.0.1 build shows the following numbers:

                              Linux IA-32               Windows IA-32
(1) AC (with JVM started)       358 Mb                     250 Mb
(2) AC (without JVM)             96 Mb                      46 Mb
------------------------------------------------------------------
(3) JVM                         260 Mb                     204 Mb
(4) Possible gain               280 %                      440 %

(2) was measured with JVM and file service disabled in AC code
(3) was calculated as (1) minus (2)
(4) was calculated as ((1) devided by (2)) minus 100%

To eliminate JVM startup and this unnecessary memory allocation, native AC File Service could be used. It is necessary to extend Backward comp. layer functionality and implement redirection of old file service requests to the native one. If some features in the native file service are absent, they could be implemented as well.

So, this enhancement could improve performance and startup time for both AC: standalone and integrated.

P.S.: Second service, the JVM is used for, is the security server.
It also could be redirected to the native AC security service when it will be implemented (e.g. #195644).
Before this, JVM could be started as before when security is enabled.
Comment 1 Guru Nagarajan CLA 2007-07-16 13:45:12 EDT
Igor,
 This is a good one. The lazy initialization of the JVM for the security case is a much needed enh and also enables additional memory for the workbench processing.
Comment 2 Chris Elford CLA 2007-08-02 17:39:23 EDT
Suggest setting tags for 4.5 discussion (if it cannot be contained in 4.4.1)
Comment 3 Igor Alelekov CLA 2007-08-30 13:53:55 EDT
Voting +3, hope this will improve AC efficiency.
Comment 4 Igor Alelekov CLA 2007-09-19 10:48:25 EDT
Created attachment 78752 [details]
patch

The patch has been test on Linux and Windows with org.eclipse.hyades.test.execution.local.FileManagerExtendedTest
Comment 5 Igor Alelekov CLA 2007-10-18 10:10:21 EDT
Created attachment 80661 [details]
Feature Description Document
Comment 6 Paul Slauenwhite CLA 2007-10-23 07:30:09 EDT
Note, this enhancement has not been reviewed/approved by the AG for 4.5.
Comment 7 Paul Slauenwhite CLA 2007-11-06 12:48:09 EST
Approved by the AG for TPTP 4.5 with the following comments:

-Since the file server is a key component of the Agent Controller (e.g. test execution), we need to ensure it is well tested.  Can the existing test cases be reused or will you write new test cases?
-Will the execution APIs on the client side need to change or will compatibility be preserved by using the same protocol?
-Very nice memory improvement.
Comment 8 Igor Alelekov CLA 2008-02-04 10:13:21 EST
Created attachment 88778 [details]
updated patch
Comment 9 Igor Alelekov CLA 2008-02-05 06:35:05 EST
Joanna, the patch is tested and ready to commit.
May I commit it right now or wait for the next iteration (i6)?
Comment 10 Igor Alelekov CLA 2008-02-05 09:46:30 EST
Resolving since the patch is committed into HEAD
Comment 11 Paul Slauenwhite CLA 2009-06-30 09:58:52 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.